On Sun, Jan 24, 2021 at 1:50 PM Thomas Munro <thomas.mu...@gmail.com> wrote: > On Sun, Jan 10, 2021 at 9:21 AM Thomas Munro <thomas.mu...@gmail.com> wrote: > > I left the fsync-after-closing and non-sync'd tests using write(), > > because they weren't using lseek(). The latter case is arguably a bit > > odd because it's not overwriting pre-allocated blocks, unlike the > > earlier tests. > > On closer inspection, the weird thing about that final test is that > it's opening and closing the file every time. That doesn't seem to > make any sense. Perhaps it's a copy and paste error from the previous > test? In v2 I changed it to pg_pwrite(), and moved the open and close > calls out of the loop.
Pushed.
