Thanks! I have pushed this patch. I didn't test on Windows, but I did
verify that it works with python2 and 3 on my Linux machine.
CLDR has made release 35 already, upon download of which the script
generates a few more lines in the unaccent.rules file, as attached.
--
Álvaro Herrera
On Mon, Mar 18, 2019 at 09:06:09AM -0400, Hugh Ranalli wrote:
> I'm not sure I'd classify the second change as "irrelevant." Using "with"
> is the standard and recommended practice for working with files in Python.
I honestly don't know about any standard way to do anythings in
Python, but it is t
On Mon, 18 Mar 2019 at 01:14, Kyotaro HORIGUCHI <
horiguchi.kyot...@lab.ntt.co.jp> wrote:
> This patch contains irrelevant changes. The minimal required
> change would be the attached. If you want refacotor the
> UnicodeData reader or rearrange import sutff, it should be
> separate patches.
>
I'm
Hello.
At Mon, 18 Mar 2019 14:13:34 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI
wrote in
<20190318.141334.186469242.horiguchi.kyot...@lab.ntt.co.jp>
> Hello.
>
> At Sun, 17 Mar 2019 20:23:05 -0400, Hugh Ranalli wrote in
>
> > Hi Ram,
> > Thanks for doing this; I've been overestimating my
Hello.
At Sun, 17 Mar 2019 20:23:05 -0400, Hugh Ranalli wrote in
> Hi Ram,
> Thanks for doing this; I've been overestimating my ability to get to things
> over the last couple of weeks.
>
> I've looked at the patch and have made one minor change. I had moved all
> the imports up to the top, to
Hi Ram,
Thanks for doing this; I've been overestimating my ability to get to things
over the last couple of weeks.
I've looked at the patch and have made one minor change. I had moved all
the imports up to the top, to keep them in one place (and I think some had
originally been used only by the Py
Hi Hugh,
I have abstracted out the windows compatibility changes from your patch to
a new patch and tested it. Added the patch to
https://commitfest.postgresql.org/23/
Please feel free to change it if it requires any changes.
Cheers
Ram 4.0
v1_unaccent_windows_compatibility.patch
Description:
On Mon, 11 Mar 2019 at 22:29, Michael Paquier wrote:
> On Mon, Mar 11, 2019 at 09:54:45PM +0530, Ramanarayana wrote:
> > I went through the python script and found that the stdout encoding is
> set
> > to utf-8 only if python version is <=2. The same needs to be done for
> > python 3
>
> If you s
On Mon, Mar 11, 2019 at 09:54:45PM +0530, Ramanarayana wrote:
> I went through the python script and found that the stdout encoding is set
> to utf-8 only if python version is <=2. The same needs to be done for
> python 3
If you send a patch for that, how would it look like? Could you also
regist
