On Mon, Mar 18, 2019 at 09:06:09AM -0400, Hugh Ranalli wrote: > I'm not sure I'd classify the second change as "irrelevant." Using "with" > is the standard and recommended practice for working with files in Python.
I honestly don't know about any standard way to do anythings in Python, but it is true that using "with" saves from a forgotten close() call. > At the moment the script does nothing to close the open data file, whether > through regular processing or in the case of an exception. I would argue > that's a bug and should be fixed. Creating a separate patch for that seems > to be adding work for no reason. This script runs in a short-lived context, so it is really not a big deal to not close the opened UnicodeData.txt. I agree that it is bad practice though, so I think it's fine to fix the problem if there is another patch touching the same area of the code while on it. -- Michael
signature.asc
Description: PGP signature
