Re: Typo in xact.c

2022-09-18 Thread John Naylor
On Fri, Sep 16, 2022 at 10:51 AM John Naylor wrote: > > On Fri, Sep 16, 2022 at 10:11 AM Kyotaro Horiguchi > wrote: > > > > The patch seems to me covering all occurances of PG_PROC as PGPROC. > > +1 since this hinders grep-ability. Pushed this. > > I found several uses of PG_PROC as (pg_catalog

Re: Typo in xact.c

2022-09-15 Thread Japin Li
On Fri, 16 Sep 2022 at 11:11, Kyotaro Horiguchi wrote: > At Thu, 15 Sep 2022 22:38:01 +0800, Japin Li wrote in >> >> Hi hacker, >> >> Recently, I find there might be a typo in xact.c comments. The comments >> say "PG_PROC", however, it actually means "PGPROC" structure. Since we >> have pg

Re: Typo in xact.c

2022-09-15 Thread Japin Li
On Fri, 16 Sep 2022 at 11:51, John Naylor wrote: > On Fri, Sep 16, 2022 at 10:11 AM Kyotaro Horiguchi > wrote: >> >> At Thu, 15 Sep 2022 22:38:01 +0800, Japin Li wrote in >> > >> > Hi hacker, >> > >> > Recently, I find there might be a typo in xact.c comments. The comments >> > say "PG_PROC",

Re: Typo in xact.c

2022-09-15 Thread John Naylor
On Fri, Sep 16, 2022 at 10:11 AM Kyotaro Horiguchi wrote: > > At Thu, 15 Sep 2022 22:38:01 +0800, Japin Li wrote in > > > > Hi hacker, > > > > Recently, I find there might be a typo in xact.c comments. The comments > > say "PG_PROC", however, it actually means "PGPROC" structure. Since we > > h

Re: Typo in xact.c

2022-09-15 Thread Kyotaro Horiguchi
At Thu, 15 Sep 2022 22:38:01 +0800, Japin Li wrote in > > Hi hacker, > > Recently, I find there might be a typo in xact.c comments. The comments > say "PG_PROC", however, it actually means "PGPROC" structure. Since we > have pg_proc catalog, and use PG_PROC to reference the catalog [1], so, >