At Thu, 15 Sep 2022 22:38:01 +0800, Japin Li <japi...@hotmail.com> wrote in > > Hi hacker, > > Recently, I find there might be a typo in xact.c comments. The comments > say "PG_PROC", however, it actually means "PGPROC" structure. Since we > have pg_proc catalog, and use PG_PROC to reference the catalog [1], so, > we should use PGPROC to reference the structure. Any thoughts? > > [1] src/include/nodes/primnodes.h
The patch seems to me covering all occurances of PG_PROC as PGPROC. I found several uses of PG_PROC as (pg_catalog.)pg_proc, which is quite confusing, too.. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
