Re: Typo in comment for pgstat_database_flush_cb()

2025-04-07 Thread Etsuro Fujita
On Sun, Apr 6, 2025 at 11:44 PM Michael Paquier wrote: > On Sun, Apr 06, 2025 at 01:31:50PM +0200, Etsuro Fujita wrote: > > +1 for both suggestions. So I modified the comment as such in each > > file with such a flush_cb function. I will push the patch. > > Thanks for the fix. Could you also ba

Re: Typo in comment for pgstat_database_flush_cb()

2025-04-06 Thread Michael Paquier
On Sun, Apr 06, 2025 at 01:31:50PM +0200, Etsuro Fujita wrote: > +1 for both suggestions. So I modified the comment as such in each > file with such a flush_cb function. I will push the patch. Thanks for the fix. Could you also backpatch that down to v15? It would be good to keep this level of

Re: Typo in comment for pgstat_database_flush_cb()

2025-04-06 Thread Etsuro Fujita
On Sun, Mar 30, 2025 at 7:54 PM Gurjeet Singh wrote: > On Sun Mar 30, 2025 at 4:39 AM PDT, Heikki Linnakangas wrote: > > On 30/03/2025 14:32, Heikki Linnakangas wrote: > >> On 30/03/2025 13:28, Etsuro Fujita wrote: > >>> Another thing I noticed is $SUBJECT: I think “if lock could not > >>> immedia

Re: Typo in comment for pgstat_database_flush_cb()

2025-03-30 Thread Gurjeet Singh
On Sun Mar 30, 2025 at 4:39 AM PDT, Heikki Linnakangas wrote: > On 30/03/2025 14:32, Heikki Linnakangas wrote: >> On 30/03/2025 13:28, Etsuro Fujita wrote: >>> Another thing I noticed is $SUBJECT: I think “if lock could not >>> immediately acquired” should be “if lock could not be immediately >>> a

Re: Typo in comment for pgstat_database_flush_cb()

2025-03-30 Thread Heikki Linnakangas
On 30/03/2025 13:28, Etsuro Fujita wrote: Another thing I noticed is $SUBJECT: I think “if lock could not immediately acquired” should be “if lock could not be immediately acquired”. Attached is a patch for that. Yep. And there are more instances of the same typo in other such flush_cb functi

Re: Typo in comment for pgstat_database_flush_cb()

2025-03-30 Thread Heikki Linnakangas
On 30/03/2025 14:32, Heikki Linnakangas wrote: On 30/03/2025 13:28, Etsuro Fujita wrote: Another thing I noticed is $SUBJECT: I think “if lock could not immediately acquired” should be “if lock could not be immediately acquired”.  Attached is a patch for that. Yep. And there are more instances

Re: Typo in comment for pgstat_database_flush_cb()

2025-03-30 Thread Tender Wang
Etsuro Fujita 于2025年3月30日周日 18:28写道: > Another thing I noticed is $SUBJECT: I think “if lock could not > immediately acquired” should be “if lock could not be immediately > acquired”. Attached is a patch for that. > Agree. The patch looks good to me. -- Thanks, Tender Wang

Re: Typo in comment of auto_explain.c

2024-11-27 Thread Ilia Evdokimov
On 27.11.2024 15:54, Heikki Linnakangas wrote: On 27/11/2024 14:46, Ilia Evdokimov wrote: Hi everyone, I found typo in comment auto_explain.c line 282 (/* Enable per-node instrumentation iff log_analyze is required. */). Not 'iff' but 'if'. It's short for "if and only if". See https://e

Re: Typo in comment of auto_explain.c

2024-11-27 Thread Heikki Linnakangas
On 27/11/2024 14:46, Ilia Evdokimov wrote: Hi everyone, I found typo in comment auto_explain.c line 282 (/* Enable per-node instrumentation iff log_analyze is required. */). Not 'iff' but 'if'. It's short for "if and only if". See https://en.wikipedia.org/wiki/If_and_only_if. There was s

Re: Typo in comment of auto_explain.c

2024-11-27 Thread Daniel Gustafsson
> On 27 Nov 2024, at 13:46, Ilia Evdokimov > wrote: > I found typo in comment auto_explain.c line 282 (/* Enable per-node > instrumentation iff log_analyze is required. */). > > Not 'iff' but 'if'. iff is a shorthand for "if and only if", which is used throughout the code. Given the number of

Re: Typo in comment

2017-11-17 Thread Etsuro Fujita
(2017/11/17 4:18), Robert Haas wrote: On Thu, Nov 16, 2017 at 6:53 AM, Etsuro Fujita wrote: Here is a patch for fixing a comment typo: s/datum1/datums1/. Thanks, committed. Thank you. Best regards, Etsuro Fujita

Re: Typo in comment

2017-11-16 Thread Robert Haas
On Thu, Nov 16, 2017 at 6:53 AM, Etsuro Fujita wrote: > Here is a patch for fixing a comment typo: s/datum1/datums1/. Thanks, committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company