On Sun Mar 30, 2025 at 4:39 AM PDT, Heikki Linnakangas wrote: > On 30/03/2025 14:32, Heikki Linnakangas wrote: >> On 30/03/2025 13:28, Etsuro Fujita wrote: >>> Another thing I noticed is $SUBJECT: I think “if lock could not >>> immediately acquired” should be “if lock could not be immediately >>> acquired”. Attached is a patch for that. >> >> Yep. And there are more instances of the same typo in other such >> flush_cb functions, if you search for "immediately acquired".
+1 for chainging other occurrences of this in other pgstat_*.c files. > While we're at it, the comment feels a bit awkward to me anyway. Maybe > rephrase it to "If nowait is true and the lock could not be immediately > acquired, returns false without flushing the entry. Otherwise returns true." This rephrasing does sounds better. Best regards, Gurjeet http://Gurje.et
