Re: Tidy recent code bloat in pg_creatersubscriber::cleanup_objects_atexit

2025-03-16 Thread Peter Smith
Thanks for pushing it. == Kind Regards, Peter Smith. Fujitsu Australia

Re: Tidy recent code bloat in pg_creatersubscriber::cleanup_objects_atexit

2025-03-16 Thread Michael Paquier
On Tue, Mar 11, 2025 at 04:06:14PM +0900, Michael Paquier wrote: > Right. This improves the clarity of the code, so agreed about the use > of a local variable here. More code paths of pg_createsubscriber.c have similar loops, but this is the only one where LogicalRepInfo can be used. So, applied

Re: Tidy recent code bloat in pg_creatersubscriber::cleanup_objects_atexit

2025-03-11 Thread Michael Paquier
On Tue, Mar 11, 2025 at 12:29:42PM +1100, Peter Smith wrote: > During a recent review of pg_creatersubscriber I saw that commit > e117cfb introduced a common 'dbinfos' struct to contain the array of > individual 'dbinfo[i]' infos. But, this now means that getting to each > dbinfo[i] requires anothe