On Tue, Mar 11, 2025 at 12:29:42PM +1100, Peter Smith wrote: > During a recent review of pg_creatersubscriber I saw that commit > e117cfb introduced a common 'dbinfos' struct to contain the array of > individual 'dbinfo[i]' infos. But, this now means that getting to each > dbinfo[i] requires another level of referencing. > > In some places, e.g. function cleanup_objects_atexit, this caused > unnecessary code bloat. IMO this function is crying out for a local > variable to simplify the code again.
Right. This improves the clarity of the code, so agreed about the use of a local variable here. -- Michael
signature.asc
Description: PGP signature
