Re: Tests "with" and "alter_table" suffer from name clash

2021-12-29 Thread Tom Lane
Thomas Munro writes: > In fact only REL_10_STABLE had the problem, because commit 2cf8c7aa > already fixed the other instance in later branches. I'd entirely > forgotten that earlier discussion, which apparently didn't quite go > far enough. So I only needed to push the with.sql change. Done.

Re: Tests "with" and "alter_table" suffer from name clash

2021-12-29 Thread Thomas Munro
On Thu, Dec 30, 2021 at 3:27 PM Tom Lane wrote: > Looks reasonable. We really should avoid using such common > names for short-lived tables in any case --- it's an invitation > to trouble. So I'd vote for changing the other use of "test", too. In fact only REL_10_STABLE had the problem, because

Re: Tests "with" and "alter_table" suffer from name clash

2021-12-29 Thread Tom Lane
Thomas Munro writes: > With unlucky scheduling you can get a failure like this: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hoverfly&dt=2021-12-22%2010%3A51%3A32 > Suggested fix attached. Looks reasonable. We really should avoid using such common names for short-lived tables in any