On 18/11/2020 08:21, Soumyadeep Chakraborty wrote:
On Tue, Nov 17, 2020 at 2:38 AM Heikki Linnakangas wrote:
Fixed all the other things you listed, fixed a bug in setting
'file_encoding', and trimmed down the #includes.
Thanks! LGTM! Marking as Ready for Committer.
Pushed, thanks for the re
On 16/11/2020 04:28, Justin Pryzby wrote:
On Tue, Nov 03, 2020 at 03:15:27PM +1300, David Rowley wrote:
On Tue, 3 Nov 2020 at 07:35, Andres Freund wrote:
On 2020-11-02 19:43:38 +0200, Heikki Linnakangas wrote:
On 02/11/2020 19:23, Andres Freund wrote:
On 2020-11-02 11:03:29 +0200, Heikki Li
On Tue, Nov 03, 2020 at 03:15:27PM +1300, David Rowley wrote:
> On Tue, 3 Nov 2020 at 07:35, Andres Freund wrote:
> >
> > On 2020-11-02 19:43:38 +0200, Heikki Linnakangas wrote:
> > > On 02/11/2020 19:23, Andres Freund wrote:
> > > > On 2020-11-02 11:03:29 +0200, Heikki Linnakangas wrote:
> > > >
Hey Heikki,
On Tue, Nov 3, 2020 at 1:30 AM Heikki Linnakangas wrote:
Thanks for working on this refactor. LGTM! I had a few minor comments:
1. We should rename the CopyFormatOptions *cstate param in
ProcessCopyOptions() to CopyFormatOptions *options and List *options to
List *raw_options IMO, t
On 2020-11-03 08:38, Heikki Linnakangas wrote:
[v3-0001-Split-copy.c-into-copyto.c-and-copyfrom.c.patch]
[v3-0002-Split-copyfrom.c-further-into-copyfrom.c-and-copy.patch]
The patches apply ok, but I get these errors:
In file included from ../../../src/include/postgres.h:46,
f
On Tue, 3 Nov 2020 at 07:35, Andres Freund wrote:
>
> On 2020-11-02 19:43:38 +0200, Heikki Linnakangas wrote:
> > On 02/11/2020 19:23, Andres Freund wrote:
> > > On 2020-11-02 11:03:29 +0200, Heikki Linnakangas wrote:
> > > > There isn't much common code between COPY FROM and COPY TO, so I propose
On 2020-11-02 19:43:38 +0200, Heikki Linnakangas wrote:
> On 02/11/2020 19:23, Andres Freund wrote:
> > On 2020-11-02 11:03:29 +0200, Heikki Linnakangas wrote:
> > > There isn't much common code between COPY FROM and COPY TO, so I propose
> > > that we split copy.c into two: copyfrom.c and copyto.c
On 02/11/2020 19:23, Andres Freund wrote:
On 2020-11-02 11:03:29 +0200, Heikki Linnakangas wrote:
There isn't much common code between COPY FROM and COPY TO, so I propose
that we split copy.c into two: copyfrom.c and copyto.c. See attached. I thin
that's much nicer.
Not quite convinced that's
Hi,
On 2020-11-02 11:03:29 +0200, Heikki Linnakangas wrote:
> While looking at the parallel copy patches, it started to annoy me how large
> copy.c is.
Agreed.
> There isn't much common code between COPY FROM and COPY TO, so I propose
> that we split copy.c into two: copyfrom.c and copyto.c. Se
On Mon, Nov 2, 2020 at 2:33 PM Heikki Linnakangas wrote:
>
> While looking at the parallel copy patches, it started to annoy me how
> large copy.c is. It confuses my little head. (Ok, it's annoyed me many
> times in the past, but I haven't done anything about it.)
>
+1 for having copy from & copy
On 2020-11-02 12:19, Heikki Linnakangas wrote:
On 02/11/2020 11:36, Erik Rijkers wrote:
On 2020-11-02 10:03, Heikki Linnakangas wrote:
While looking at the parallel copy patches, it started to annoy me
how
large copy.c is. It confuses my little head. (Ok, it's annoyed me
many
times in the pas
On 2020-11-02 10:03, Heikki Linnakangas wrote:
While looking at the parallel copy patches, it started to annoy me how
large copy.c is. It confuses my little head. (Ok, it's annoyed me many
times in the past, but I haven't done anything about it.)
[0001-Split-copy.c-into-...o.c-and-copyfrom.c.p
12 matches
Mail list logo
