Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2022-04-07 Thread Masahiko Sawada
On Fri, Apr 8, 2022 at 1:37 PM Michael Paquier wrote: > > On Fri, Apr 08, 2022 at 11:34:17AM +0900, Michael Paquier wrote: > > Now, 0002 is straight-forward but I need more coffee and lunch.. > > Done this one as well, as of 76cbf7e with few tweaks. 1.9 and 1.10 > changed the definition of pg_sta

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2022-04-07 Thread Michael Paquier
On Fri, Apr 08, 2022 at 11:34:17AM +0900, Michael Paquier wrote: > Now, 0002 is straight-forward but I need more coffee and lunch.. Done this one as well, as of 76cbf7e with few tweaks. 1.9 and 1.10 changed the definition of pg_stat_statements, so I have added two extra queries for those upgrade

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2022-04-07 Thread Michael Paquier
On Thu, Apr 07, 2022 at 09:48:02PM +0900, Masahiko Sawada wrote: > Oops, the results are opposite: > > HEAD: 5367.234 ms > Patched: 5418.869 ms I have been playing with external sorts & friends after running an instance on scissors (fsync=off, PGDATA on tmpfs, etc.), even forcing a compilation of

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2022-04-07 Thread Masahiko Sawada
On Thu, Apr 7, 2022 at 5:52 PM Masahiko Sawada wrote: > > On Thu, Apr 7, 2022 at 4:55 PM Julien Rouhaud wrote: > > > > On Thu, Apr 07, 2022 at 04:24:54PM +0900, Michael Paquier wrote: > > > On Thu, Apr 07, 2022 at 03:14:01PM +0800, Julien Rouhaud wrote: > > > > Sure, but gettimeofday() has been i

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2022-04-07 Thread Masahiko Sawada
On Thu, Apr 7, 2022 at 4:55 PM Julien Rouhaud wrote: > > On Thu, Apr 07, 2022 at 04:24:54PM +0900, Michael Paquier wrote: > > On Thu, Apr 07, 2022 at 03:14:01PM +0800, Julien Rouhaud wrote: > > > Sure, but gettimeofday() has been implemented in vDSO for quite some time > > > on > > > most platfor

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2022-04-07 Thread Julien Rouhaud
On Thu, Apr 07, 2022 at 04:24:54PM +0900, Michael Paquier wrote: > On Thu, Apr 07, 2022 at 03:14:01PM +0800, Julien Rouhaud wrote: > > Sure, but gettimeofday() has been implemented in vDSO for quite some time on > > most platforms, so it shouldn't hurt that much on mainstream platforms > > especial

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2022-04-07 Thread Michael Paquier
On Thu, Apr 07, 2022 at 03:14:01PM +0800, Julien Rouhaud wrote: > Sure, but gettimeofday() has been implemented in vDSO for quite some time on > most platforms, so it shouldn't hurt that much on mainstream platforms > especially compared to the cost of whatever operation is actually using that > te

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2022-04-07 Thread Julien Rouhaud
On Thu, Apr 07, 2022 at 03:58:46PM +0900, Michael Paquier wrote: > On Tue, Apr 05, 2022 at 11:57:14AM +0800, Julien Rouhaud wrote: > > This is a minor detail and the rest of the patch looks good to me, so I'm > > marking the patch as Ready for Committer! > > @@ -440,10 +442,14 @@ BufFileLoadBuffer

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2022-04-06 Thread Michael Paquier
On Tue, Apr 05, 2022 at 11:57:14AM +0800, Julien Rouhaud wrote: > This is a minor detail and the rest of the patch looks good to me, so I'm > marking the patch as Ready for Committer! @@ -440,10 +442,14 @@ BufFileLoadBuffer(BufFile *file) + if (track_io_timing) + INSTR_TIME_SET_CURRENT(io_

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2022-04-04 Thread Julien Rouhaud
On Tue, Apr 05, 2022 at 10:40:04AM +0900, Masahiko Sawada wrote: > On Tue, Apr 5, 2022 at 1:31 AM Julien Rouhaud wrote: > > > > Yes. In normal circumstances it shouldn't need a lot of time to do that, > > but > > I'm not so sure with e.g. network filesystems. I'm not strongly in favor of > > co

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2022-04-04 Thread Masahiko Sawada
On Tue, Apr 5, 2022 at 1:31 AM Julien Rouhaud wrote: > > On Tue, Apr 05, 2022 at 12:51:12AM +0900, Masahiko Sawada wrote: > > On Mon, Apr 4, 2022 at 1:30 PM Julien Rouhaud wrote: > > > > > > Hmm, but AFAICS the json format would be stable as the counters are always > > > shown even if zero. So j

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2022-04-04 Thread Julien Rouhaud
On Tue, Apr 05, 2022 at 12:51:12AM +0900, Masahiko Sawada wrote: > On Mon, Apr 4, 2022 at 1:30 PM Julien Rouhaud wrote: > > > > Hmm, but AFAICS the json format would be stable as the counters are always > > shown even if zero. So just doing the json format first and then the text > > format shoul

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2022-04-04 Thread Masahiko Sawada
On Mon, Apr 4, 2022 at 1:30 PM Julien Rouhaud wrote: > > Hi, > > On Tue, Mar 01, 2022 at 11:35:32AM +0900, Masahiko Sawada wrote: > > On Wed, Jan 19, 2022 at 5:52 PM Julien Rouhaud wrote: > > > > > > It seems that the regression tests aren't entirely stable, per cfbot: > > > https://cirrus-ci.com

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2022-04-03 Thread Julien Rouhaud
Hi, On Tue, Mar 01, 2022 at 11:35:32AM +0900, Masahiko Sawada wrote: > On Wed, Jan 19, 2022 at 5:52 PM Julien Rouhaud wrote: > > > > It seems that the regression tests aren't entirely stable, per cfbot: > > https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/36/3298. > > > > The f

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2022-02-28 Thread Masahiko Sawada
On Wed, Jan 19, 2022 at 5:52 PM Julien Rouhaud wrote: > > Hi, > > On Tue, Nov 16, 2021 at 04:37:44PM +0900, Masahiko Sawada wrote: > > > > I've attached an updated patch. Please review it. > > It seems that the regression tests aren't entirely stable, per cfbot: > https://cirrus-ci.com/github/post

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2022-02-28 Thread Masahiko Sawada
Hi, Sorry for the late reply. On Fri, Nov 19, 2021 at 7:24 AM Melanie Plageman wrote: > > On Sun, Aug 22, 2021 at 9:47 PM Masahiko Sawada wrote: > > > > On Thu, Aug 19, 2021 at 10:52 PM Ranier Vilela wrote: > > > > > > Em qui., 19 de ago. de 2021 às 09:21, Masahiko Sawada > > > escreveu: > >

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2022-01-19 Thread Julien Rouhaud
Hi, On Tue, Nov 16, 2021 at 04:37:44PM +0900, Masahiko Sawada wrote: > > I've attached an updated patch. Please review it. It seems that the regression tests aren't entirely stable, per cfbot: https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/36/3298. The failures look like:

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2021-11-18 Thread Melanie Plageman
On Sun, Aug 22, 2021 at 9:47 PM Masahiko Sawada wrote: > > On Thu, Aug 19, 2021 at 10:52 PM Ranier Vilela wrote: > > > > Em qui., 19 de ago. de 2021 às 09:21, Masahiko Sawada > > escreveu: > > > The presentation seems a little confusing, wouldn't it be better? > > > > I/O Timings: shared/local

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2021-11-15 Thread Masahiko Sawada
On Tue, Sep 7, 2021 at 12:02 AM wrote: > > Hi, > > ‐‐‐ Original Message ‐‐‐ > On Tuesday, August 24th, 2021 at 13:20, Ranier Vilela > wrote: > > > Em ter., 24 de ago. de 2021 às 03:11, Masahiko Sawada > > escreveu: > > > > > On Mon, Aug 23, 2021 at 10:46 AM Masahiko Sawada > > > wrot

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2021-09-06 Thread gkokolatos
Hi, ‐‐‐ Original Message ‐‐‐ On Tuesday, August 24th, 2021 at 13:20, Ranier Vilela wrote: > Em ter., 24 de ago. de 2021 às 03:11, Masahiko Sawada > escreveu: > > > On Mon, Aug 23, 2021 at 10:46 AM Masahiko Sawada > > wrote: > > > > > > > > On Thu, Aug 19, 2021 at 10:52 PM Ranier Vil

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2021-08-24 Thread Ranier Vilela
Em ter., 24 de ago. de 2021 às 03:11, Masahiko Sawada escreveu: > On Mon, Aug 23, 2021 at 10:46 AM Masahiko Sawada > wrote: > > > > On Thu, Aug 19, 2021 at 10:52 PM Ranier Vilela > wrote: > > > > > > Em qui., 19 de ago. de 2021 às 09:21, Masahiko Sawada < > sawada.m...@gmail.com> escreveu: > >

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2021-08-23 Thread Masahiko Sawada
On Mon, Aug 23, 2021 at 10:46 AM Masahiko Sawada wrote: > > On Thu, Aug 19, 2021 at 10:52 PM Ranier Vilela wrote: > > > > Em qui., 19 de ago. de 2021 às 09:21, Masahiko Sawada > > escreveu: > >> > >> Hi all , > >> > >> It's reported on pgsql-bugs[1] that I/O timings in EXPLAIN don't show > >> t

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2021-08-22 Thread Masahiko Sawada
On Thu, Aug 19, 2021 at 10:52 PM Ranier Vilela wrote: > > Em qui., 19 de ago. de 2021 às 09:21, Masahiko Sawada > escreveu: >> >> Hi all , >> >> It's reported on pgsql-bugs[1] that I/O timings in EXPLAIN don't show >> the one for temp files. I think it's not a bug but could be an item >> for PG1

Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN

2021-08-19 Thread Ranier Vilela
Em qui., 19 de ago. de 2021 às 09:21, Masahiko Sawada escreveu: > Hi all , > > It's reported on pgsql-bugs[1] that I/O timings in EXPLAIN don't show > the one for temp files. I think it's not a bug but could be an item > for PG15. As mentioned on that thread, this would be useful for users > in a