Re: Show inline comments from pg_hba lines in the pg_hba_file_rules view

2023-09-01 Thread Jim Jones
On 01.09.23 12:44, Michael Paquier wrote: I am not sure what you have in mind, but IMO any solution would live better as long as a solution is: - not linked to hba.c, handled in a separate code path. - linked to all configuration files where comments are supported, if need be. If I understood y

Re: Show inline comments from pg_hba lines in the pg_hba_file_rules view

2023-09-01 Thread Michael Paquier
On Fri, Sep 01, 2023 at 11:32:35AM +0200, Jim Jones wrote: > Would you be in favor of parsing #comments instead? Given that # is > currently already being parsed (ignored), it shouldn't add too much > complexity to the code. I am not sure what you have in mind, but IMO any solution would live bett

Re: Show inline comments from pg_hba lines in the pg_hba_file_rules view

2023-09-01 Thread Jim Jones
Hi Michael On 01.09.23 03:18, Michael Paquier wrote: hba.c is complex enough these days (inclusion logic, tokenization of the items) that I am not in favor of touching its code paths for anything like that. This is not something that can apply only to pg_hba.conf, but to all configuration files

Re: Show inline comments from pg_hba lines in the pg_hba_file_rules view

2023-08-31 Thread Michael Paquier
On Fri, Sep 01, 2023 at 12:01:37AM +0200, Jim Jones wrote: > Often we make changes in the pg_hba.conf and leave a #comment there, just in > case we forget why the change was done. To avoid having to open the > configuration file every time just to check the comments, it would be quite > nice to hav