Re: Rename PageData to XLogPageData

2024-10-04 Thread Peter Eisentraut
On 04.10.24 05:55, Michael Paquier wrote: On Thu, Oct 03, 2024 at 01:31:19PM +0200, Peter Eisentraut wrote: Sounds good. Here is an updated version. Good idea. What you have sent here looks good to me. committed

Re: Rename PageData to XLogPageData

2024-10-03 Thread Michael Paquier
On Thu, Oct 03, 2024 at 01:31:19PM +0200, Peter Eisentraut wrote: > Sounds good. Here is an updated version. Good idea. What you have sent here looks good to me. -- Michael signature.asc Description: PGP signature

Re: Rename PageData to XLogPageData

2024-10-03 Thread Peter Eisentraut
On 02.10.24 19:02, Heikki Linnakangas wrote: This patch renames that type to a more specific name XLogPageData. This makes room for possibly adding another PageData type with the earlier meaning, but that's not done here.  But I think even without that, this patch is a useful little cleanup th

Re: Rename PageData to XLogPageData

2024-10-02 Thread Heikki Linnakangas
On 02/10/2024 14:30, Peter Eisentraut wrote: I was fiddling a bit with making some Page-related APIs const-proof, which might involve changing something like "Page p" to "const PageData *p", but I was surprised that a type PageData exists but it's an unrelated type local to generic_xlog.c. Go