On 02/10/2024 14:30, Peter Eisentraut wrote:
I was fiddling a bit with making some Page-related APIs const-proof, which might involve changing something like "Page p" to "const PageData *p", but I was surprised that a type PageData exists but it's an unrelated type local to generic_xlog.c.
Good find
This patch renames that type to a more specific name XLogPageData. This makes room for possibly adding another PageData type with the earlier meaning, but that's not done here. But I think even without that, this patch is a useful little cleanup that makes the code more consistent and clear.
+1 for renaming, but -1 on XLogPageData. That sounds like a WAL page, see XLogPageHeaderData for example. I'd suggest GenericXLogPageData or just GenericPerPageData or something.
-- Heikki Linnakangas Neon (https://neon.tech)
