Re: Redundant syscache access in get_rel_sync_entry()

2024-07-11 Thread Tom Lane
Michael Paquier writes: > On Thu, Jul 11, 2024 at 07:10:58PM +0530, Ashutosh Bapat wrote: >> I think it's just convenient. We do that at multiple places; not exactly >> these functions but functions which fetch relation attributes from cached >> tuples. Given that the tuple is cached and local to

Re: Redundant syscache access in get_rel_sync_entry()

2024-07-11 Thread Michael Paquier
On Thu, Jul 11, 2024 at 07:10:58PM +0530, Ashutosh Bapat wrote: > I think it's just convenient. We do that at multiple places; not exactly > these functions but functions which fetch relation attributes from cached > tuples. Given that the tuple is cached and local to the backend, it's not > too ex

Re: Redundant syscache access in get_rel_sync_entry()

2024-07-11 Thread cca5507
-- Original -- From: "Ashutosh Bapat"

Re: Redundant syscache access in get_rel_sync_entry()

2024-07-11 Thread Ashutosh Bapat
On Thu, Jul 11, 2024 at 11:38 AM cca5507 wrote: > Hi, > in func get_rel_sync_entry() we access the same tuple in pg_class three > times: > Oid schemaId = get_rel_namespace(relid); > bool am_partition = get_rel_relispartition(relid); > char relkind = get_rel_relkind(relid); > W