Re: Redundant syscache access in get_rel_sync_entry()

[cca5507]

------------------ Original ------------------
From:                                                                           
                                             "Ashutosh Bapat"                   
                                                                 
<ashutosh.bapat....@gmail.com&gt;;
Date:&nbsp;Thu, Jul 11, 2024 09:40 PM
To:&nbsp;"cca5507"<cca5...@qq.com&gt;;
Cc:&nbsp;"pgsql-hackers"<pgsql-hackers@lists.postgresql.org&gt;;
Subject:&nbsp;Re: Redundant syscache access in get_rel_sync_entry()

I think it's just convenient. We do that at multiple places; not exactly these 
functions but functions which fetch relation attributes from cached tuples. 
Given that the tuple is cached and local to the backend, it's not too 
expensive.&nbsp; But if there are multiple places which do something like this, 
we may want to create more function&nbsp;get_rel_* function which&nbsp;return 
multiple properties in one function call. I see get_rel_namspace() and 
get_rel_name() called together at many places.


Agreed


Thank you for reply


--
Regards,
ChangAo Chen