Re: Preserve subscription OIDs during pg_upgrade

2024-03-05 Thread Aleksander Alekseev
Hi, > It will be better to preserve them as it will be easier to > compare subscription related objects in pg_subscription and > pg_subscription_rel in the old and new clusters. IMO it would be helpful if you could give a little bit more context on why/when this is useful. Personally I find it so

Re: Preserve subscription OIDs during pg_upgrade

2024-03-04 Thread Bruce Momjian
On Mon, Feb 26, 2024 at 09:51:40AM +0530, Robert Haas wrote: > > I am not sure that it is a good idea to relax that for PG17 at this > > stage of the development cycle, though, as we have already done a lot > > in this area for pg_upgrade and it may require more tweaks during the > > beta period de

Re: Preserve subscription OIDs during pg_upgrade

2024-02-25 Thread Robert Haas
On Mon, Feb 26, 2024 at 6:07 AM Michael Paquier wrote: > I think that the idea behind that it that it would then become > possible to relax the restrictions related to the states of the > relations stored in pg_subscription_rel, which can now be only a > "ready" or "init" state (see check_old_clus

Re: Preserve subscription OIDs during pg_upgrade

2024-02-25 Thread Michael Paquier
On Sun, Feb 25, 2024 at 11:34:35AM -0500, Tom Lane wrote: > vignesh C writes: >> Recently we have supported upgrade of subscriptions,but currently >> subscription OIDs can be changed when a cluster is upgraded using >> pg_upgrade. It will be better to preserve them as it will be easier to >> compa

Re: Preserve subscription OIDs during pg_upgrade

2024-02-25 Thread Tom Lane
vignesh C writes: > Recently we have supported upgrade of subscriptions,but currently > subscription OIDs can be changed when a cluster is upgraded using > pg_upgrade. It will be better to preserve them as it will be easier to > compare subscription related objects in pg_subscription and > pg_subs