Re: Offsets of `struct Port` are no longer constant

2024-11-22 Thread Jacob Champion
On Fri, Nov 22, 2024 at 8:06 AM Heikki Linnakangas wrote: > Ok, committed the "placeholder" fields to master, and just comment fixes > to REL_17_STABLE. Thanks! --Jacob

Re: Offsets of `struct Port` are no longer constant

2024-11-22 Thread Heikki Linnakangas
On 11/11/2024 21:43, Daniel Gustafsson wrote: On 11 Nov 2024, at 20:17, Jacob Champion wrote: On Mon, Nov 11, 2024 at 11:13 AM Heikki Linnakangas wrote: On REL_17_STABLE, we should probably adjust the comment to warn that 'raw_buf' and friends can move depending on USE_OPENSSL. Yeah, make

Re: Offsets of `struct Port` are no longer constant

2024-11-11 Thread Daniel Gustafsson
> On 11 Nov 2024, at 20:17, Jacob Champion > wrote: > > On Mon, Nov 11, 2024 at 11:13 AM Heikki Linnakangas wrote: >> On REL_17_STABLE, we should probably adjust the comment to warn that >> 'raw_buf' and friends can move depending on USE_OPENSSL. > > Yeah, makes sense. +1

Re: Offsets of `struct Port` are no longer constant

2024-11-11 Thread Jacob Champion
On Mon, Nov 11, 2024 at 11:13 AM Heikki Linnakangas wrote: > On REL_17_STABLE, we should probably adjust the comment to warn that > 'raw_buf' and friends can move depending on USE_OPENSSL. Yeah, makes sense. --Jacob

Re: Offsets of `struct Port` are no longer constant

2024-11-11 Thread Heikki Linnakangas
On 11/11/2024 18:34, Jacob Champion wrote: Hi all, A comment at the end of the Port struct says /* * OpenSSL structures. (Keep these last so that the locations of other * fields are the same whether or not you build with SSL enabled.) */ but as part of th