On 11/11/2024 18:34, Jacob Champion wrote:
Hi all,A comment at the end of the Port struct says /* * OpenSSL structures. (Keep these last so that the locations of other * fields are the same whether or not you build with SSL enabled.) */ but as part of the direct-SSL changes in d39a49c1e45 (cc'd Heikki), some additional fields snuck in after it. I assume it's too late to change this for 17, but should this be addressed in HEAD? I've attached a draft patch (untested, beware) which should no longer rely on field order.
Oops. Fortunately this is not likely to cause trouble in practice, I can't imagine an extension peeking into 'raw_buf' and friends. But yeah, we should do something at least on HEAD. +1 on your patch; I'll commit that unless someone has better ideas.
On REL_17_STABLE, we should probably adjust the comment to warn that 'raw_buf' and friends can move depending on USE_OPENSSL.
-- Heikki Linnakangas Neon (https://neon.tech)
