On Mon, Aug 4, 2025 at 3:49 AM Bertrand Drouvot
wrote:
>
> On Fri, Aug 01, 2025 at 03:04:20PM -0400, Melanie Plageman wrote:
>
> > but it does not import usleep as other tests do (like this)
> > use Time::HiRes qw(usleep);
> >
> > I think it simply hasn't been called because postgres exits and
> >
On Mon, Aug 4, 2025 at 3:52 AM Bertrand Drouvot
wrote:
>
> On Sat, Aug 02, 2025 at 08:09:14AM +0900, Michael Paquier wrote:
>
> > Not the author of these two ones, but am I the only one who does not
> > see the point of these two tests? These check that something does not
> > happen,
> >
> > Woul
Hi,
On Sat, Aug 02, 2025 at 08:09:14AM +0900, Michael Paquier wrote:
> On Fri, Aug 01, 2025 at 03:22:06PM -0700, Masahiko Sawada wrote:
> > On Fri, Aug 1, 2025 at 1:58 PM Melanie Plageman
> > wrote:
> >> Another issue I see is that there are two incorrect tests for a log message
> >>
> >> # messa
Hi,
On Fri, Aug 01, 2025 at 04:57:50PM -0400, Melanie Plageman wrote:
> On Fri, Aug 1, 2025 at 3:04 PM Melanie Plageman
> wrote:
> >
> > 035_standby_logical_decoding.pl has this code
>
> Another issue I see is that there are two incorrect tests for a log message
>
> # message should not be issu
Hi,
On Fri, Aug 01, 2025 at 03:04:20PM -0400, Melanie Plageman wrote:
> Hi,
>
> 035_standby_logical_decoding.pl has this code
>
> # wait for postgres to terminate
> foreach my $i (0 .. 10 * $PostgreSQL::Test::Utils::timeout_default)
> {
> last if !-f $node_standby->data_dir . '/postmaster.pi
On Fri, Aug 01, 2025 at 03:22:06PM -0700, Masahiko Sawada wrote:
> On Fri, Aug 1, 2025 at 1:58 PM Melanie Plageman
> wrote:
>> Another issue I see is that there are two incorrect tests for a log message
>>
>> # message should not be issued
>> ok( !$node_standby->log_contains(
>> "invalidat
On Fri, Aug 1, 2025 at 1:58 PM Melanie Plageman
wrote:
>
> On Fri, Aug 1, 2025 at 3:04 PM Melanie Plageman
> wrote:
> >
> > 035_standby_logical_decoding.pl has this code
>
> Another issue I see is that there are two incorrect tests for a log message
>
> # message should not be issued
> ok( !$node
On Fri, Aug 1, 2025 at 12:04 PM Melanie Plageman
wrote:
>
> Hi,
>
> 035_standby_logical_decoding.pl has this code
>
> # wait for postgres to terminate
> foreach my $i (0 .. 10 * $PostgreSQL::Test::Utils::timeout_default)
> {
> last if !-f $node_standby->data_dir . '/postmaster.pid';
> usle
On Fri, Aug 1, 2025 at 3:04 PM Melanie Plageman
wrote:
>
> 035_standby_logical_decoding.pl has this code
Another issue I see is that there are two incorrect tests for a log message
# message should not be issued
ok( !$node_standby->log_contains(
"invalidating obsolete slot \"no_conflict_
