On Fri, Aug 1, 2025 at 1:58 PM Melanie Plageman <melanieplage...@gmail.com> wrote: > > On Fri, Aug 1, 2025 at 3:04 PM Melanie Plageman > <melanieplage...@gmail.com> wrote: > > > > 035_standby_logical_decoding.pl has this code > > Another issue I see is that there are two incorrect tests for a log message > > # message should not be issued > ok( !$node_standby->log_contains( > "invalidating obsolete slot \"no_conflict_inactiveslot\"", $logstart), > 'inactiveslot slot invalidation is not logged with vacuum on > conflict_test' > ); > > ok( !$node_standby->log_contains( > "invalidating obsolete slot \"no_conflict_activeslot\"", $logstart), > 'activeslot slot invalidation is not logged with vacuum on conflict_test' > ); > > This will never fail because the message string is actually > "invalidating obsolete replication slot" > > It is correctly specified elsewhere in the same test. > so, that should be fixed too.
+1 Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
