Re: Incorrect comment in be-secure-openssl.c

2020-06-03 Thread Michael Paquier
On Wed, Jun 03, 2020 at 02:40:54PM +0200, Daniel Gustafsson wrote: > Sounds good, thanks! Okay, done then. -- Michael signature.asc Description: PGP signature

Re: Incorrect comment in be-secure-openssl.c

2020-06-03 Thread Daniel Gustafsson
> On 3 Jun 2020, at 14:38, Michael Paquier wrote: > > On Mon, Jun 01, 2020 at 10:39:45AM +0200, Daniel Gustafsson wrote: >> I don't have a problem with the existing wording of the first sentence, and I >> don't have a problem with your suggestion either (as long as it's parameters >> in >> plura

Re: Incorrect comment in be-secure-openssl.c

2020-06-03 Thread Michael Paquier
On Mon, Jun 01, 2020 at 10:39:45AM +0200, Daniel Gustafsson wrote: > I don't have a problem with the existing wording of the first sentence, and I > don't have a problem with your suggestion either (as long as it's parameters > in > plural). Thanks, that's why I kept the word plural in my own sug

Re: Incorrect comment in be-secure-openssl.c

2020-06-01 Thread Daniel Gustafsson
> On 1 Jun 2020, at 08:06, Michael Paquier wrote: > The problem I have with first and second flavors is that "DH > parameters files" does not sound right. First, the grammar sounds > incorrect to me as in this case "parameters" should not be plural. I think "parameters" is the right term here,

Re: Incorrect comment in be-secure-openssl.c

2020-05-31 Thread Michael Paquier
On Sun, May 31, 2020 at 05:47:01PM -0400, Robert Haas wrote: > On Sun, May 31, 2020 at 2:54 AM Michael Paquier wrote: > I don't understand why that change is an improvement. Oops. I have managed to copy-paste an incorrect diff. The existing comment is that: * To prevent problems if the DH para

Re: Incorrect comment in be-secure-openssl.c

2020-05-31 Thread Robert Haas
On Sun, May 31, 2020 at 2:54 AM Michael Paquier wrote: > On Fri, May 29, 2020 at 02:38:53PM +0900, Michael Paquier wrote: > > Indeed, looks good to me. I'll go fix, ust let's wait and see first > > if others have any comments. > > Actually, I was reading again the new sentence, and did not like i

Re: Incorrect comment in be-secure-openssl.c

2020-05-30 Thread Michael Paquier
On Fri, May 29, 2020 at 02:38:53PM +0900, Michael Paquier wrote: > Indeed, looks good to me. I'll go fix, ust let's wait and see first > if others have any comments. Actually, I was reading again the new sentence, and did not like its first part. Here is a rework that looks much better to me:

Re: Incorrect comment in be-secure-openssl.c

2020-05-28 Thread Michael Paquier
On Thu, May 28, 2020 at 05:15:17PM +0200, Daniel Gustafsson wrote: > The comment in be-secure-openssl.c didn't get the memo that the hardcoded DH > parameters moved in 573bd08b99e277026e87bb55ae69c489fab321b8. The attached > updates the wording, keeping it generic enough that we wont need to updat