Re: Improvements in Copy From

2020-09-11 Thread Kyotaro Horiguchi
At Fri, 11 Sep 2020 18:44:13 +1000, Peter Smith wrote in > On Thu, Sep 10, 2020 at 9:21 PM vignesh C wrote: > > > Whether such a micro-optimisation is worth doing is another question. > > Yes, what you suggested can also be done, but even I have the same > > question as you. Because we will red

Re: Improvements in Copy From

2020-09-11 Thread Peter Smith
On Thu, Sep 10, 2020 at 9:21 PM vignesh C wrote: > > Whether such a micro-optimisation is worth doing is another question. > Yes, what you suggested can also be done, but even I have the same > question as you. Because we will reduce just one function call, the > eof check is present immediately i

Re: Improvements in Copy From

2020-09-10 Thread Kyotaro Horiguchi
At Thu, 10 Sep 2020 21:55:27 +0300, Surafel Temesgen wrote in > On Thu, Sep 10, 2020 at 1:17 PM vignesh C wrote: > > > > > > > > > We have a patch for column matching feature [1] that may need a header > > line to be further processed. Even without that I think it is preferable to > > process

Re: Improvements in Copy From

2020-09-10 Thread Surafel Temesgen
On Thu, Sep 10, 2020 at 1:17 PM vignesh C wrote: > > > > > We have a patch for column matching feature [1] that may need a header > line to be further processed. Even without that I think it is preferable to > process the header line for nothing than adding those checks to the loop, > performance

Re: Improvements in Copy From

2020-09-10 Thread vignesh C
On Wed, Sep 9, 2020 at 12:24 PM Peter Smith wrote: > > My basic understanding of first part of your patch is that by > adjusting the "minread" it now allows it to loop multiple times > internally within the CopyGetData rather than calling CopyLoadRawBuf > for every N lines. There doesn't seem to b

Re: Improvements in Copy From

2020-09-10 Thread vignesh C
On Mon, Sep 7, 2020 at 1:19 PM Surafel Temesgen wrote: > > > Hi Vignesh > > On Wed, Jul 1, 2020 at 3:46 PM vignesh C wrote: >> >> Hi, >> >> While reviewing copy from I identified few improvements for copy from >> that can be done : >> a) copy from stdin copies lesser amount of data to buffer eve

Re: Improvements in Copy From

2020-09-08 Thread Peter Smith
My basic understanding of first part of your patch is that by adjusting the "minread" it now allows it to loop multiple times internally within the CopyGetData rather than calling CopyLoadRawBuf for every N lines. There doesn't seem to be much change to what other code gets executed so the saving i

Re: Improvements in Copy From

2020-09-07 Thread Surafel Temesgen
Hi Vignesh On Wed, Jul 1, 2020 at 3:46 PM vignesh C wrote: > Hi, > > While reviewing copy from I identified few improvements for copy from > that can be done : > a) copy from stdin copies lesser amount of data to buffer even though > space is available in buffer because minread was passed as 1

Re: Improvements in Copy From

2020-08-30 Thread vignesh C
On Thu, Aug 27, 2020 at 11:02 AM Peter Smith wrote: > > Hello. > > FYI - that patch has conflicts when applied. > Thanks for letting me know. Attached new patch which is rebased on top of head. Regards, VIgnesh EnterpriseDB: http://www.enterprisedb.com From a343fe1f8fdf4293d2ef6841e243390b99f29e

Re: Improvements in Copy From

2020-08-26 Thread Peter Smith
Hello. FYI - that patch has conflicts when applied. Kind Regards Peter Smith Fujitsu Australia. On Thu, Aug 27, 2020 at 3:11 PM vignesh C wrote: > > On Tue, Jul 14, 2020 at 12:17 PM vignesh C wrote: > > > > On Tue, Jul 14, 2020 at 11:13 AM David Rowley wrote: > > > > > > On Tue, 14 Jul 2020 a

Re: Improvements in Copy From

2020-07-14 Thread vignesh C
On Tue, Jul 14, 2020 at 12:17 PM vignesh C wrote: > > On Tue, Jul 14, 2020 at 11:13 AM David Rowley wrote: > > > > On Tue, 14 Jul 2020 at 17:22, David Rowley wrote: > > > > > > On Thu, 2 Jul 2020 at 00:46, vignesh C wrote: > > > > b) CopyMultiInsertInfoNextFreeSlot had an unused function parame

Re: Improvements in Copy From

2020-07-13 Thread vignesh C
On Tue, Jul 14, 2020 at 11:13 AM David Rowley wrote: > > On Tue, 14 Jul 2020 at 17:22, David Rowley wrote: > > > > On Thu, 2 Jul 2020 at 00:46, vignesh C wrote: > > > b) CopyMultiInsertInfoNextFreeSlot had an unused function parameter > > > that is not being used, it can be removed. > > > > This

Re: Improvements in Copy From

2020-07-13 Thread David Rowley
On Tue, 14 Jul 2020 at 17:22, David Rowley wrote: > > On Thu, 2 Jul 2020 at 00:46, vignesh C wrote: > > b) CopyMultiInsertInfoNextFreeSlot had an unused function parameter > > that is not being used, it can be removed. > > This was raised in [1]. We decided not to remove it. I just added a comme

Re: Improvements in Copy From

2020-07-13 Thread David Rowley
On Thu, 2 Jul 2020 at 00:46, vignesh C wrote: > b) CopyMultiInsertInfoNextFreeSlot had an unused function parameter > that is not being used, it can be removed. This was raised in [1]. We decided not to remove it. David [1] https://www.postgresql.org/message-id/flat/CAKJS1f-A5aYvPHe10Wy9LjC4Rz

Re: Improvements in Copy From

2020-07-13 Thread vignesh C
On Wed, Jul 1, 2020 at 6:16 PM vignesh C wrote: > Attached patch has the changes for the same. > Thoughts? > Added a commitfest entry for this: https://commitfest.postgresql.org/29/2642/ Regards, Vignesh EnterpriseDB: http://www.enterprisedb.com