On Tue, 14 Jul 2020 at 17:22, David Rowley <dgrowle...@gmail.com> wrote: > > On Thu, 2 Jul 2020 at 00:46, vignesh C <vignes...@gmail.com> wrote: > > b) CopyMultiInsertInfoNextFreeSlot had an unused function parameter > > that is not being used, it can be removed. > > This was raised in [1]. We decided not to remove it.
I just added a comment to the function to mention why we want to keep the parameter. I hope that will save any wasted time proposing its removal in the future. FWIW, the function is inlined. Removing it will gain us nothing performance-wise anyway. David > [1] > https://www.postgresql.org/message-id/flat/CAKJS1f-A5aYvPHe10Wy9LjC4RzLsBrya8b2gfuQHFabhwZT_NQ%40mail.gmail.com#3bae9a84be253c527b0e621add0fbaef
