On 15.08.24 09:20, Michael Banck wrote:
On Wed, Aug 14, 2024 at 06:05:19PM -0700, Jeff Davis wrote:
That looks good to me. Does anyone have a different opinion? If not,
I'll go ahead and commit (but not backport) this change.
What is the rationale not to backpatch this? The error message chang
Hi,
On Wed, Aug 14, 2024 at 06:05:19PM -0700, Jeff Davis wrote:
> That looks good to me. Does anyone have a different opinion? If not,
> I'll go ahead and commit (but not backport) this change.
What is the rationale not to backpatch this? The error message changes,
but we do not translate configu
On Fri, 2024-08-09 at 11:44 +0200, Michael Banck wrote:
> So maybe the better change is to just remove the explicit error
> message
> again and depend on PKG_CHECK_MODULES erroring out helpfully? The
> downside would be that the hint about specifying --without-icu to get
> around this would disapp
On 09.08.24 10:59, Heikki Linnakangas wrote:
On 09/08/2024 11:16, Michael Banck wrote:
Hi,
Holger Jacobs complained in pgsql-admin that in v17, if you have the ICU
development libraries installed but not pkg-config, you get a somewhat
unhelpful error message about ICU not being present:
|check
Hi,
adding Jeff to CC as he changed the way ICU configure detection was done
in fcb21b3.
On Fri, Aug 09, 2024 at 11:59:12AM +0300, Heikki Linnakangas wrote:
> On 09/08/2024 11:16, Michael Banck wrote:
> > Hi,
> >
> > Holger Jacobs complained in pgsql-admin that in v17, if you have the ICU
> > de
On 09/08/2024 11:16, Michael Banck wrote:
Hi,
Holger Jacobs complained in pgsql-admin that in v17, if you have the ICU
development libraries installed but not pkg-config, you get a somewhat
unhelpful error message about ICU not being present:
|checking for pkg-config... no
|checking whether to
Meh, forgot the attachment. Also, this should be backpatched to v17 if
accepted.
Michael
>From b696949180437a3c7307ac0509cba54828b44259 Mon Sep 17 00:00:00 2001
From: Michael Banck
Date: Fri, 9 Aug 2024 10:13:27 +0200
Subject: [PATCH] Improve configure error for ICU libraries if pkg-config is
a
