On Wed, Mar 30, 2022 at 9:54 PM vignesh C wrote:
>
> On Wed, Mar 30, 2022 at 5:42 PM Bharath Rupireddy
> wrote:
>
> Your suggestion looks valid, I have modified it as suggested.
> Additionally I have removed Create subscription with multiple
> non-existent publications and changed add publication
On Wed, Mar 30, 2022 at 5:42 PM Bharath Rupireddy
wrote:
>
> On Wed, Mar 30, 2022 at 5:37 PM Bharath Rupireddy
> wrote:
> >
> > On Wed, Mar 30, 2022 at 4:29 PM Amit Kapila wrote:
> > >
> > > On Wed, Mar 30, 2022 at 12:22 PM vignesh C wrote:
> > > >
> > > > I have made the changes for this, atta
On Wed, Mar 30, 2022 at 5:37 PM Bharath Rupireddy
wrote:
>
> On Wed, Mar 30, 2022 at 4:29 PM Amit Kapila wrote:
> >
> > On Wed, Mar 30, 2022 at 12:22 PM vignesh C wrote:
> > >
> > > I have made the changes for this, attached v17 patch has the changes
> > > for the same.
> > >
> >
> > The patch l
On Wed, Mar 30, 2022 at 4:29 PM Amit Kapila wrote:
>
> On Wed, Mar 30, 2022 at 12:22 PM vignesh C wrote:
> >
> > I have made the changes for this, attached v17 patch has the changes
> > for the same.
> >
>
> The patch looks good to me. I have made minor edits in the comments
> and docs. See the a
On Wed, Mar 30, 2022 at 12:22 PM vignesh C wrote:
>
> I have made the changes for this, attached v17 patch has the changes
> for the same.
>
The patch looks good to me. I have made minor edits in the comments
and docs. See the attached and let me know what you think? I intend to
commit this tomor
On Wed, Mar 30, 2022 at 11:22 AM Amit Kapila wrote:
>
> On Tue, Mar 29, 2022 at 8:11 PM vignesh C wrote:
> >
> > On Tue, Mar 29, 2022 at 11:02 AM Amit Kapila
> > wrote:
> > >
> >
> > Thanks for the suggestion, I have changed the patch as suggested.
> > Attached v16 patch has the changes for the
On Tue, Mar 29, 2022 at 8:11 PM vignesh C wrote:
>
> On Tue, Mar 29, 2022 at 11:02 AM Amit Kapila wrote:
> >
>
> Thanks for the suggestion, I have changed the patch as suggested.
> Attached v16 patch has the changes for the same.
>
Thanks, I have one more comment.
postgres=# Alter subscription
On Tue, Mar 29, 2022 at 4:12 PM Amit Kapila wrote:
>
> On Tue, Mar 29, 2022 at 11:01 AM Amit Kapila wrote:
> >
> > On Sat, Mar 26, 2022 at 7:53 PM vignesh C wrote:
> > >
> > > The patch was not applying on HEAD, attached patch which is rebased on
> > > top of HEAD.
> > >
> >
> > IIUC, this patch
On Tue, Mar 29, 2022 at 11:02 AM Amit Kapila wrote:
>
> On Sat, Mar 26, 2022 at 7:53 PM vignesh C wrote:
> >
> > The patch was not applying on HEAD, attached patch which is rebased on
> > top of HEAD.
> >
>
> IIUC, this patch provides an option that allows us to give an error if
> while creating/
On Tue, Mar 29, 2022 at 11:01 AM Amit Kapila wrote:
>
> On Sat, Mar 26, 2022 at 7:53 PM vignesh C wrote:
> >
> > The patch was not applying on HEAD, attached patch which is rebased on
> > top of HEAD.
> >
>
> IIUC, this patch provides an option that allows us to give an error if
> while creating/
On Sat, Mar 26, 2022 at 7:53 PM vignesh C wrote:
>
> The patch was not applying on HEAD, attached patch which is rebased on
> top of HEAD.
>
IIUC, this patch provides an option that allows us to give an error if
while creating/altering subcsiction, user gives non-existant
publications. I am not s
On Tue, Mar 22, 2022 at 3:23 PM vignesh C wrote:
>
> On Tue, Mar 22, 2022 at 5:29 AM Andres Freund wrote:
> >
> > On 2022-02-13 19:34:05 +0530, vignesh C wrote:
> > > Thanks for the comments, the attached v14 patch has the changes for the
> > > same.
> >
> > The patch needs a rebase, it currentl
On Tue, Mar 22, 2022 at 5:29 AM Andres Freund wrote:
>
> On 2022-02-13 19:34:05 +0530, vignesh C wrote:
> > Thanks for the comments, the attached v14 patch has the changes for the
> > same.
>
> The patch needs a rebase, it currently fails to apply:
> http://cfbot.cputube.org/patch_37_2957.log
Th
On 2022-02-13 19:34:05 +0530, vignesh C wrote:
> Thanks for the comments, the attached v14 patch has the changes for the same.
The patch needs a rebase, it currently fails to apply:
http://cfbot.cputube.org/patch_37_2957.log
Thanks for working on the review comments. The changes in the new
patch look good to me. I am marking it as ready to commit.
--
With Regards,
Ashutosh Sharma.
On Sun, Feb 13, 2022 at 7:34 PM vignesh C wrote:
>
> On Fri, Feb 11, 2022 at 7:14 PM Ashutosh Sharma wrote:
> >
> > I have spent little
Thanks for working on my review comments. I'll take a look at the new
changes and let you know my comments, if any. I didn't get a chance to
check it out today as I was busy reviewing some other patches, but
I'll definitely take a look at the new patch in a day or so and let
you know my feedback.
On Sun, Feb 13, 2022 at 7:32 PM vignesh C wrote:
>
> On Thu, Feb 10, 2022 at 3:15 PM Ashutosh Sharma wrote:
> >
> > On Wed, Feb 9, 2022 at 11:53 PM Euler Taveira wrote:
> > >
> > > On Wed, Feb 9, 2022, at 12:06 PM, Ashutosh Sharma wrote:
> > >
> > > Just wondering if we should also be detecting
On Fri, Feb 11, 2022 at 7:14 PM Ashutosh Sharma wrote:
>
> I have spent little time looking at the latest patch. The patch looks
> to be in good shape as it has already been reviewed by many people
> here, although I did get some comments. Please take a look and let me
> know your thoughts.
>
>
>
On Thu, Feb 10, 2022 at 3:15 PM Ashutosh Sharma wrote:
>
> On Wed, Feb 9, 2022 at 11:53 PM Euler Taveira wrote:
> >
> > On Wed, Feb 9, 2022, at 12:06 PM, Ashutosh Sharma wrote:
> >
> > Just wondering if we should also be detecting the incorrect conninfo
> > set with ALTER SUBSCRIPTION command as
I have spent little time looking at the latest patch. The patch looks
to be in good shape as it has already been reviewed by many people
here, although I did get some comments. Please take a look and let me
know your thoughts.
+ /* Try to connect to the publisher. */
+ wrconn = walrcv_connect
On Wed, Feb 9, 2022 at 11:53 PM Euler Taveira wrote:
>
> On Wed, Feb 9, 2022, at 12:06 PM, Ashutosh Sharma wrote:
>
> Just wondering if we should also be detecting the incorrect conninfo
> set with ALTER SUBSCRIPTION command as well. See below:
>
> -- try creating a subscription with incorrect con
On Wed, Feb 9, 2022, at 12:06 PM, Ashutosh Sharma wrote:
> Just wondering if we should also be detecting the incorrect conninfo
> set with ALTER SUBSCRIPTION command as well. See below:
>
> -- try creating a subscription with incorrect conninfo. the command fails.
> postgres=# create subscription
Just wondering if we should also be detecting the incorrect conninfo
set with ALTER SUBSCRIPTION command as well. See below:
-- try creating a subscription with incorrect conninfo. the command fails.
postgres=# create subscription sub1 connection 'host=localhost
port=5490 dbname=postgres' publicat
On Sat, Nov 13, 2021 at 12:50 PM vignesh C wrote:
>
> Thanks for the comments, the attached v13 patch has the fixes for the same.
Thanks for the updated v13 patch. I have no further comments, it looks
good to me.
Regards,
Bharath Rupireddy.
On Wed, Nov 10, 2021 at 11:16 AM Bharath Rupireddy
wrote:
>
> On Tue, Nov 9, 2021 at 9:27 PM vignesh C wrote:
> > Attached v12 version is rebased on top of Head.
>
> Thanks for the patch. Here are some comments on v12:
>
> 1) I think ERRCODE_TOO_MANY_ARGUMENTS isn't the right error code, the
> ER
On Tue, Nov 9, 2021 at 9:27 PM vignesh C wrote:
> Attached v12 version is rebased on top of Head.
Thanks for the patch. Here are some comments on v12:
1) I think ERRCODE_TOO_MANY_ARGUMENTS isn't the right error code, the
ERRCODE_UNDEFINED_OBJECT is more meaningful. Please change.
+ ereport(ERROR
On Tue, Sep 28, 2021 at 7:49 AM Jaime Casanova
wrote:
>
> On Thu, Aug 26, 2021 at 07:49:49PM +0530, vignesh C wrote:
> > On Thu, Jul 15, 2021 at 5:57 PM vignesh C wrote:
> > >
> > > On Tue, Jul 6, 2021 at 8:09 PM vignesh C wrote:
> > > >
> > > > On Wed, Jun 30, 2021 at 8:23 PM vignesh C wrote:
On Thu, Aug 26, 2021 at 07:49:49PM +0530, vignesh C wrote:
> On Thu, Jul 15, 2021 at 5:57 PM vignesh C wrote:
> >
> > On Tue, Jul 6, 2021 at 8:09 PM vignesh C wrote:
> > >
> > > On Wed, Jun 30, 2021 at 8:23 PM vignesh C wrote:
> > > >
> > > > On Sun, Jun 6, 2021 at 11:55 AM vignesh C wrote:
> >
On Thu, Jul 15, 2021 at 5:57 PM vignesh C wrote:
>
> On Tue, Jul 6, 2021 at 8:09 PM vignesh C wrote:
> >
> > On Wed, Jun 30, 2021 at 8:23 PM vignesh C wrote:
> > >
> > > On Sun, Jun 6, 2021 at 11:55 AM vignesh C wrote:
> > > >
> > > > On Fri, May 7, 2021 at 6:44 PM vignesh C wrote:
> > > > >
>
On Tue, Jul 6, 2021 at 8:09 PM vignesh C wrote:
>
> On Wed, Jun 30, 2021 at 8:23 PM vignesh C wrote:
> >
> > On Sun, Jun 6, 2021 at 11:55 AM vignesh C wrote:
> > >
> > > On Fri, May 7, 2021 at 6:44 PM vignesh C wrote:
> > > >
> > > > Thanks for the comments, the attached patch has the fix for t
On Wed, Jun 30, 2021 at 8:23 PM vignesh C wrote:
>
> On Sun, Jun 6, 2021 at 11:55 AM vignesh C wrote:
> >
> > On Fri, May 7, 2021 at 6:44 PM vignesh C wrote:
> > >
> > > Thanks for the comments, the attached patch has the fix for the same.
> >
> > The patch was not applying on the head, attached
On Sun, Jun 6, 2021 at 11:55 AM vignesh C wrote:
>
> On Fri, May 7, 2021 at 6:44 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached patch has the fix for the same.
>
> The patch was not applying on the head, attached patch which is rebased on
> HEAD.
The patch was not applying on
On Fri, May 7, 2021 at 6:44 PM vignesh C wrote:
>
> On Fri, May 7, 2021 at 5:44 PM Dilip Kumar wrote:
> >
> > On Fri, May 7, 2021 at 5:38 PM Bharath Rupireddy
> > wrote:
> > >
> > > On Fri, May 7, 2021 at 11:50 AM Dilip Kumar wrote:
> > > >
> > > > On Thu, May 6, 2021 at 7:22 PM vignesh C wrot
On Fri, May 7, 2021 at 5:44 PM Dilip Kumar wrote:
>
> On Fri, May 7, 2021 at 5:38 PM Bharath Rupireddy
> wrote:
> >
> > On Fri, May 7, 2021 at 11:50 AM Dilip Kumar wrote:
> > >
> > > On Thu, May 6, 2021 at 7:22 PM vignesh C wrote:
> > > >
> > >
> > > Some comments:
> > > 1.
> > > I don't see an
On Fri, May 7, 2021 at 5:38 PM Bharath Rupireddy
wrote:
>
> On Fri, May 7, 2021 at 11:50 AM Dilip Kumar wrote:
> >
> > On Thu, May 6, 2021 at 7:22 PM vignesh C wrote:
> > >
> >
> > Some comments:
> > 1.
> > I don't see any change in pg_dump.c, don't we need to dump this option?
>
> I don't think
On Fri, May 7, 2021 at 11:50 AM Dilip Kumar wrote:
>
> On Thu, May 6, 2021 at 7:22 PM vignesh C wrote:
> >
>
> Some comments:
> 1.
> I don't see any change in pg_dump.c, don't we need to dump this option?
I don't think it is necessary there as the default value of the
validate_publication is fal
On Thu, May 6, 2021 at 7:22 PM vignesh C wrote:
>
Some comments:
1.
I don't see any change in pg_dump.c, don't we need to dump this option?
2.
+ /* Try to connect to the publisher. */
+ wrconn = walrcv_connect(sub->conninfo, true, sub->name, &err);
+ if (!wrconn)
+ ereport(ERROR,
+ (errmsg("coul
On Thu, 06 May 2021 at 21:52, vignesh C wrote:
> On Thu, May 6, 2021 at 9:08 AM Japin Li wrote:
>> 3) Should we free the memory when finish the check_publications()?
>> + publicationsCopy = list_copy(publications);
>
> I felt this list entries will be deleted in the success case, in error
On Thu, May 6, 2021 at 9:08 AM Japin Li wrote:
>
>
> On Tue, 04 May 2021 at 21:20, vignesh C wrote:
> > On Tue, May 4, 2021 at 2:37 PM Bharath Rupireddy
> > wrote:
> >>
> >> On Mon, May 3, 2021 at 7:59 PM vignesh C wrote:
> >> > Thanks for the comments, these comments are handle in the v7 patch
On Tue, 04 May 2021 at 21:20, vignesh C wrote:
> On Tue, May 4, 2021 at 2:37 PM Bharath Rupireddy
> wrote:
>>
>> On Mon, May 3, 2021 at 7:59 PM vignesh C wrote:
>> > Thanks for the comments, these comments are handle in the v7 patch
>> > posted in my earlier mail.
>>
>> Thanks. Some comments o
On Tue, May 4, 2021 at 6:50 PM vignesh C wrote:
> Thanks for the comments, Attached patch has the fixes for the same.
Thanks! I took a final look over the v8 patch, it looks good to me and
regression tests were passed with it. I have no further comments at
this moment. I will make it "ready for c
On Tue, May 4, 2021 at 2:37 PM Bharath Rupireddy
wrote:
>
> On Mon, May 3, 2021 at 7:59 PM vignesh C wrote:
> > Thanks for the comments, these comments are handle in the v7 patch
> > posted in my earlier mail.
>
> Thanks. Some comments on v7 patch:
>
> 1) How about "Add publication names from the
On Mon, May 3, 2021 at 7:59 PM vignesh C wrote:
> Thanks for the comments, these comments are handle in the v7 patch
> posted in my earlier mail.
Thanks. Some comments on v7 patch:
1) How about "Add publication names from the list to a string."
instead of
* Append the list of publication to de
On Mon, May 3, 2021 at 11:11 AM Bharath Rupireddy
wrote:
>
> On Sun, May 2, 2021 at 10:04 PM vignesh C wrote:
> > > 5) Instead of adding a new file 021_validate_publications.pl for
> > > tests, spawning a new test database which would make the overall
> > > regression slower, can't we add with th
On Mon, May 3, 2021 at 1:46 PM Dilip Kumar wrote:
>
> On Mon, May 3, 2021 at 10:48 AM Dilip Kumar wrote:
> >
> > On Sun, May 2, 2021 at 10:04 PM vignesh C wrote:
> > >
> > > Thanks for the comments.
> > > The Attached patch has the fixes for the same.
> >
> > I was reviewing the documentation pa
On Mon, May 3, 2021 at 10:48 AM Dilip Kumar wrote:
>
> On Sun, May 2, 2021 at 10:04 PM vignesh C wrote:
> >
> > Thanks for the comments.
> > The Attached patch has the fixes for the same.
>
> I was reviewing the documentation part, I think in the below paragraph
> we should include validate_publi
On Sun, May 2, 2021 at 10:04 PM vignesh C wrote:
> > 5) Instead of adding a new file 021_validate_publications.pl for
> > tests, spawning a new test database which would make the overall
> > regression slower, can't we add with the existing database nodes in
> > 0001_rep_changes.pl? I would sugges
On Sun, May 2, 2021 at 10:04 PM vignesh C wrote:
>
> Thanks for the comments.
> The Attached patch has the fixes for the same.
I was reviewing the documentation part, I think in the below paragraph
we should include validate_publication as well?
connect (boolean)
On Sat, May 1, 2021 at 7:58 PM Bharath Rupireddy
wrote:
>
> On Sat, May 1, 2021 at 12:49 PM vignesh C wrote:
> > Thanks for the comments, Attached patch has the fixes for the same.
> > Thoughts?
>
> Few more comments on v5:
>
> 1) Deletion of below empty new line is spurious:
> -
> /*
> * Comm
On Sat, May 1, 2021 at 12:49 PM vignesh C wrote:
> Thanks for the comments, Attached patch has the fixes for the same.
> Thoughts?
Few more comments on v5:
1) Deletion of below empty new line is spurious:
-
/*
* Common option parsing function for CREATE and ALTER SUBSCRIPTION commands.
*
2
On Tue, Apr 13, 2021 at 8:01 PM Bharath Rupireddy
wrote:
>
> On Tue, Apr 13, 2021 at 6:22 PM vignesh C wrote:
> > > 2) How about
> > > + Specifies whether the subscriber must verify the
> > > publications that are
> > > + being subscribed to are present in the publisher. By default
On Tue, Apr 13, 2021 at 6:22 PM vignesh C wrote:
> > 2) How about
> > + Specifies whether the subscriber must verify the
> > publications that are
> > + being subscribed to are present in the publisher. By default,
> > the subscriber
> > instead of
> > + Specifies whether t
On Thu, Apr 8, 2021 at 12:13 PM Bharath Rupireddy
wrote:
>
> On Wed, Apr 7, 2021 at 10:37 PM vignesh C wrote:
> > > I think, we can also have validate_publication option allowed for
> > > ALTER SUBSCRIPTION SET PUBLICATION and REFRESH PUBLICATION commands
> > > with the same behaviour i.e. error
On Wed, Apr 7, 2021 at 10:37 PM vignesh C wrote:
> > I think, we can also have validate_publication option allowed for
> > ALTER SUBSCRIPTION SET PUBLICATION and REFRESH PUBLICATION commands
> > with the same behaviour i.e. error out when specified publications
> > don't exist in the publisher. Th
On Thu, Mar 4, 2021 at 1:04 PM Bharath Rupireddy
wrote:
>
> On Wed, Mar 3, 2021 at 8:59 AM Euler Taveira wrote:
> >
> > On Wed, Feb 3, 2021, at 2:13 AM, Bharath Rupireddy wrote:
> >
> > On Mon, Jan 25, 2021 at 10:32 PM vignesh C wrote:
> >
> > > If a publication which does not exist is specified
On Wed, Mar 3, 2021 at 8:59 AM Euler Taveira wrote:
>
> On Wed, Feb 3, 2021, at 2:13 AM, Bharath Rupireddy wrote:
>
> On Mon, Jan 25, 2021 at 10:32 PM vignesh C wrote:
>
> > If a publication which does not exist is specified during create
> > subscription, then we should throw an error similar t
On Wed, Feb 3, 2021, at 2:13 AM, Bharath Rupireddy wrote:
> On Mon, Jan 25, 2021 at 10:32 PM vignesh C wrote:
>
> > If a publication which does not exist is specified during create
> > subscription, then we should throw an error similar to step 2 behavior.
> > Similarly if a publication which d
On Mon, Jan 25, 2021 at 10:32 PM vignesh C wrote:
> > I mean it doesn’t seem right to disallow to create the subscription if
> > the publisher doesn't exist, and my reasoning was even though the
> > publisher exists while creating the subscription you might drop it
> > later right?. So basically,
On Mon, 25 Jan 2021 at 21:55, Bharath Rupireddy
wrote:
> On Mon, Jan 25, 2021 at 5:18 PM japin wrote:
>> > Do you mean when we drop publications from a subscription? If yes, do
>> > we have a way to drop a publication from the subscription? See below
>> > one of my earlier questions on this.
>
On Mon, Jan 25, 2021 at 3:07 PM Dilip Kumar wrote:
>
> On Mon, Jan 25, 2021 at 2:48 PM Bharath Rupireddy
> wrote:
> >
> > On Mon, Jan 25, 2021 at 2:42 PM Dilip Kumar
wrote:
> > >
> > > On Mon, Jan 25, 2021 at 1:10 PM vignesh C wrote:
> > > >
> > > > On Thu, Jan 21, 2021 at 10:21 PM Bharath Rupi
On Mon, Jan 25, 2021 at 5:18 PM japin wrote:
>
>
> On Mon, 25 Jan 2021 at 17:18, Bharath Rupireddy
> wrote:
> > On Mon, Jan 25, 2021 at 2:42 PM Dilip Kumar wrote:
> >>
> >> On Mon, Jan 25, 2021 at 1:10 PM vignesh C wrote:
> >> >
> >> > On Thu, Jan 21, 2021 at 10:21 PM Bharath Rupireddy
> >> >
On Mon, Jan 25, 2021 at 5:18 PM japin wrote:
> > Do you mean when we drop publications from a subscription? If yes, do
> > we have a way to drop a publication from the subscription? See below
> > one of my earlier questions on this.
> > "I wonder, why isn't dropping a publication from a list of
>
On Mon, 25 Jan 2021 at 17:18, Bharath Rupireddy
wrote:
> On Mon, Jan 25, 2021 at 2:42 PM Dilip Kumar wrote:
>>
>> On Mon, Jan 25, 2021 at 1:10 PM vignesh C wrote:
>> >
>> > On Thu, Jan 21, 2021 at 10:21 PM Bharath Rupireddy
>> > wrote:
>> > >
>> > > On Thu, Jan 21, 2021 at 6:56 PM vignesh C
On Mon, Jan 25, 2021 at 3:38 PM Bharath Rupireddy
wrote:
>
> On Mon, Jan 25, 2021 at 3:07 PM Dilip Kumar wrote:
> > > > So basically, the create subscription will throw an error if the
> > > > publication does not exist. So will you throw an error if we try to
> > > > drop the publication which
On Mon, Jan 25, 2021 at 3:07 PM Dilip Kumar wrote:
> > > So basically, the create subscription will throw an error if the
> > > publication does not exist. So will you throw an error if we try to
> > > drop the publication which is subscribed by some subscription? I mean
> > > basically, you are
On Mon, Jan 25, 2021 at 2:48 PM Bharath Rupireddy
wrote:
>
> On Mon, Jan 25, 2021 at 2:42 PM Dilip Kumar wrote:
> >
> > On Mon, Jan 25, 2021 at 1:10 PM vignesh C wrote:
> > >
> > > On Thu, Jan 21, 2021 at 10:21 PM Bharath Rupireddy
> > > wrote:
> > > >
> > > > On Thu, Jan 21, 2021 at 6:56 PM vi
On Mon, Jan 25, 2021 at 2:42 PM Dilip Kumar wrote:
>
> On Mon, Jan 25, 2021 at 1:10 PM vignesh C wrote:
> >
> > On Thu, Jan 21, 2021 at 10:21 PM Bharath Rupireddy
> > wrote:
> > >
> > > On Thu, Jan 21, 2021 at 6:56 PM vignesh C wrote:
> > > >
> > > > Hi,
> > > >
> > > > Creating/altering subscr
On Mon, Jan 25, 2021 at 1:10 PM vignesh C wrote:
>
> On Thu, Jan 21, 2021 at 10:21 PM Bharath Rupireddy
> wrote:
> >
> > On Thu, Jan 21, 2021 at 6:56 PM vignesh C wrote:
> > >
> > > Hi,
> > >
> > > Creating/altering subscription is successful when we specify a
> > > publication which does not ex
On Thu, Jan 21, 2021 at 10:21 PM Bharath Rupireddy
wrote:
>
> On Thu, Jan 21, 2021 at 6:56 PM vignesh C wrote:
> >
> > Hi,
> >
> > Creating/altering subscription is successful when we specify a
> > publication which does not exist in the publisher. I felt we should
> > throw an error in this case
On Fri, Jan 22, 2021 at 10:14 AM japin wrote:
>
>
> On Fri, 22 Jan 2021 at 00:51, Bharath Rupireddy
> wrote:
> > On Thu, Jan 21, 2021 at 6:56 PM vignesh C wrote:
> >>
> >> Hi,
> >>
> >> Creating/altering subscription is successful when we specify a
> >> publication which does not exist in the p
On Fri, Jan 22, 2021 at 12:14 PM Bharath Rupireddy
wrote:
>
> On Fri, Jan 22, 2021 at 10:14 AM japin wrote:
> > > 2) Can't we know whether the publications exist on the publisher with
> > > the existing (or modifying it a bit if required) query in
> > > fetch_table_list(), so that we can avoid ma
On Fri, Jan 22, 2021 at 10:14 AM japin wrote:
> > 2) Can't we know whether the publications exist on the publisher with
> > the existing (or modifying it a bit if required) query in
> > fetch_table_list(), so that we can avoid making another connection to
> > the publisher system from the subscrib
On Fri, 22 Jan 2021 at 00:51, Bharath Rupireddy
wrote:
> On Thu, Jan 21, 2021 at 6:56 PM vignesh C wrote:
>>
>> Hi,
>>
>> Creating/altering subscription is successful when we specify a
>> publication which does not exist in the publisher. I felt we should
>> throw an error in this case, that w
On Thu, Jan 21, 2021 at 6:56 PM vignesh C wrote:
>
> Hi,
>
> Creating/altering subscription is successful when we specify a
> publication which does not exist in the publisher. I felt we should
> throw an error in this case, that will help the user to check if there
> is any typo in the create sub
74 matches
Mail list logo
