On Sun, Feb 13, 2022 at 7:32 PM vignesh C <vignes...@gmail.com> wrote: > > On Thu, Feb 10, 2022 at 3:15 PM Ashutosh Sharma <ashu.coe...@gmail.com> wrote: > > > > On Wed, Feb 9, 2022 at 11:53 PM Euler Taveira <eu...@eulerto.com> wrote: > > > > > > On Wed, Feb 9, 2022, at 12:06 PM, Ashutosh Sharma wrote: > > > > > > Just wondering if we should also be detecting the incorrect conninfo > > > set with ALTER SUBSCRIPTION command as well. See below: > > > > > > -- try creating a subscription with incorrect conninfo. the command fails. > > > postgres=# create subscription sub1 connection 'host=localhost > > > port=5490 dbname=postgres' publication pub1; > > > ERROR: could not connect to the publisher: connection to server at > > > "localhost" (::1), port 5490 failed: Connection refused > > > Is the server running on that host and accepting TCP/IP connections? > > > connection to server at "localhost" (127.0.0.1), port 5490 failed: > > > Connection refused > > > Is the server running on that host and accepting TCP/IP connections? > > > > > > That's because by default 'connect' parameter is true. > > > > > > > So can we use this option with the ALTER SUBSCRIPTION command. I think > > we can't, which means if the user sets wrong conninfo using ALTER > > SUBSCRIPTION command then we don't have the option to detect it like > > we have in case of CREATE SUBSCRIPTION command. Since this thread is > > trying to add the ability to identify the wrong/missing publication > > name specified with the ALTER SUBSCRIPTION command, can't we do the > > same for the wrong conninfo? > > I felt this can be extended once this feature is committed. Thoughts? >
I think that should be okay. I just wanted to share with you people to know if it can be taken care of in this patch itself but it's ok if we see it later. -- With Regards, Ashutosh Sharma.
