On Sat, Jul 30, 2022 at 6:59 PM houzj.f...@fujitsu.com
wrote:
>
> On Saturday, July 30, 2022 7:25 PM Amit Kapila
> wrote:
> >
> > On Fri, Jul 29, 2022 at 3:55 PM Amit Kapila wrote:
> > >
> > > On Fri, Jul 29, 2022 at 3:29 PM Alvaro Herrera
> > wrote:
> > > >
> > > > Well, I checked the commit
On Saturday, July 30, 2022 7:25 PM Amit Kapila wrote:
>
> On Fri, Jul 29, 2022 at 3:55 PM Amit Kapila wrote:
> >
> > On Fri, Jul 29, 2022 at 3:29 PM Alvaro Herrera
> wrote:
> > >
> > > Well, I checked the commit and the functions I was talking about
> > > look OK now. However, looking again, p
On Fri, Jul 29, 2022 at 3:55 PM Amit Kapila wrote:
>
> On Fri, Jul 29, 2022 at 3:29 PM Alvaro Herrera
> wrote:
> >
> > Well, I checked the commit and the functions I was talking about look OK
> > now. However, looking again, pg_relation_is_publishable is in the wrong
> > place (should be right
On Fri, Jul 29, 2022 at 3:29 PM Alvaro Herrera wrote:
>
> On 2022-Jul-29, Peter Smith wrote:
>
> > On Fri, Jul 29, 2022 at 7:36 PM Alvaro Herrera
> > wrote:
> > >
> > > I don't object to doing this, but I think these two functions should
> > > stay together nonetheless.
> >
> > If you believe th
On 2022-Jul-29, Peter Smith wrote:
> On Fri, Jul 29, 2022 at 7:36 PM Alvaro Herrera
> wrote:
> >
> > I don't object to doing this, but I think these two functions should
> > stay together nonetheless.
>
> If you believe there is still a problem after applying the patch
> please explicitly name
On Fri, Jul 29, 2022 at 7:36 PM Alvaro Herrera wrote:
>
> On 2022-Jul-29, Peter Smith wrote:
>
> > PSA v2 of this patch, modified as suggested.
>
> I don't object to doing this, but I think these two functions should
> stay together nonetheless.
Hmm, I think there is some confusion because diffe
On 2022-Jul-29, Peter Smith wrote:
> PSA v2 of this patch, modified as suggested.
I don't object to doing this, but I think these two functions should
stay together nonetheless.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
Y una voz del caos me habló y me dij
PSA v2 of this patch, modified as suggested.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
v2-0001-Functions-is_publishable_class-and-is_publishable.patch
Description: Binary data
On Fri, Jul 29, 2022 at 8:26 AM Peter Smith wrote:
>
> On Fri, Jul 29, 2022 at 11:55 AM houzj.f...@fujitsu.com
> wrote:
> >
> > On Friday, July 29, 2022 7:17 AM Peter Smith wrote:
> > > During a recent review, I happened to notice that in the file
> > > src/backend/catalog/pg_publication.c the t
On Fri, Jul 29, 2022 at 11:55 AM houzj.f...@fujitsu.com
wrote:
>
> On Friday, July 29, 2022 7:17 AM Peter Smith wrote:
> > During a recent review, I happened to notice that in the file
> > src/backend/catalog/pg_publication.c the two functions
> > 'is_publishable_class'
> > and 'is_publishable_r
On Friday, July 29, 2022 7:17 AM Peter Smith wrote:
> During a recent review, I happened to notice that in the file
> src/backend/catalog/pg_publication.c the two functions 'is_publishable_class'
> and 'is_publishable_relation' used to be [1] adjacent in the source code.
> This is
> also evident
11 matches
Mail list logo
