Re: Fix possible overflow of pg_stat DSA's refcnt

2024-06-26 Thread Michael Paquier
On Wed, Jun 26, 2024 at 08:48:06AM +0200, Anthonin Bonnefoy wrote: > Yeah, this happened last week on one of our replicas (version 15.5) > last week that had 134 days uptime. We are doing a lot of parallel > queries on this cluster so the combination of high uptime plus > parallel workers creation

Re: Fix possible overflow of pg_stat DSA's refcnt

2024-06-25 Thread Anthonin Bonnefoy
On Wed, Jun 26, 2024 at 7:40 AM Michael Paquier wrote: > > Very good catch! It looks like you have seen that in the field, then. > Sad face. Yeah, this happened last week on one of our replicas (version 15.5) last week that had 134 days uptime. We are doing a lot of parallel queries on this clus

Re: Fix possible overflow of pg_stat DSA's refcnt

2024-06-25 Thread Michael Paquier
On Tue, Jun 25, 2024 at 05:01:55PM +0200, Anthonin Bonnefoy wrote: > During backend initialisation, pgStat DSA is attached using > dsa_attach_in_place with a NULL segment. The NULL segment means that > there's no callback to release the DSA when the process exits. > pgstat_detach_shmem only calls d