Re: Fix lwlock.c and wait_event_names.txt discrepancy

2025-07-18 Thread Bertrand Drouvot
Hi, On Thu, Jul 17, 2025 at 02:25:46PM +, Bertrand Drouvot wrote: > Hi, > > On Thu, Jul 17, 2025 at 09:50:12AM +0900, Michael Paquier wrote: > > On Wed, Jul 16, 2025 at 11:41:09AM +, Bertrand Drouvot wrote: > > > > > As a way to prevent this to occur we might want to add extra input file

Re: Fix lwlock.c and wait_event_names.txt discrepancy

2025-07-17 Thread Bertrand Drouvot
Hi, On Thu, Jul 17, 2025 at 09:50:12AM +0900, Michael Paquier wrote: > On Wed, Jul 16, 2025 at 11:41:09AM +, Bertrand Drouvot wrote: > > > As a way to prevent this to occur we might want to add extra input file(s) > > parameter to generate-wait_event_types.pl (as proposed in [1]). > > > > [1

Re: Fix lwlock.c and wait_event_names.txt discrepancy

2025-07-16 Thread Michael Paquier
On Wed, Jul 16, 2025 at 11:41:09AM +, Bertrand Drouvot wrote: > On Wed, Jul 16, 2025 at 01:33:07PM +0200, Álvaro Herrera wrote: >> I don't. These names are unlikely to be anywhere other than in the >> output of queries for any length of time, so if we change them now, >> nothing will break per

Re: Fix lwlock.c and wait_event_names.txt discrepancy

2025-07-16 Thread Bertrand Drouvot
Hi, On Wed, Jul 16, 2025 at 01:33:07PM +0200, Álvaro Herrera wrote: > On 2025-Jul-16, Michael Paquier wrote: > > > On Wed, Jul 16, 2025 at 09:30:31AM +, Bertrand Drouvot wrote: > > > > Indeed, the wait event names are MultixactOffsetSLRU and > > > MultixactMemberSLRU in > > > the C file but

Re: Fix lwlock.c and wait_event_names.txt discrepancy

2025-07-16 Thread Álvaro Herrera
On 2025-Jul-16, Michael Paquier wrote: > On Wed, Jul 16, 2025 at 09:30:31AM +, Bertrand Drouvot wrote: > > Indeed, the wait event names are MultixactOffsetSLRU and > > MultixactMemberSLRU in > > the C file but MultiXactOffsetSLRU and MultiXactMemberSLRU in the text file. > > > > That breaks

Re: Fix lwlock.c and wait_event_names.txt discrepancy

2025-07-16 Thread Michael Paquier
On Wed, Jul 16, 2025 at 09:30:31AM +, Bertrand Drouvot wrote: > While working on [1], I noticed a discrepancy between lwlock.c and > wait_event_names.txt for 2 wait events. Oops. > Indeed, the wait event names are MultixactOffsetSLRU and MultixactMemberSLRU > in > the C file but MultiXactOff