On Wed, Jul 16, 2025 at 11:41:09AM +0000, Bertrand Drouvot wrote: > On Wed, Jul 16, 2025 at 01:33:07PM +0200, Álvaro Herrera wrote: >> I don't. These names are unlikely to be anywhere other than in the >> output of queries for any length of time, so if we change them now, >> nothing will break permanently. I grant that there might be small >> temporary breakage if somebody is storing wait event samples or similar, >> but I doubt it'll be a problem to change it. Long-term lack of >> joinability between pg_stat_activity and pg_wait_events in the 17 branch >> would likely be a bigger problem. > > +1
Thanks. Perhaps I am worrying to much about the profiles taken on REL_17_STABLE, but after sleeping on it the long-term picture is better if we are consistent on all the branches, so done down to v17. Thanks for the report. > As a way to prevent this to occur we might want to add extra input file(s) > parameter to generate-wait_event_types.pl (as proposed in [1]). > > [1]: > https://www.postgresql.org/message-id/flat/aDQdDhcwMHjZRhSV%40ip-10-97-1-34.eu-west-3.compute.internal That's the second issue so far, so we had better do so. -- Michael
signature.asc
Description: PGP signature
