On Tue, Nov 19, 2024 at 2:37 PM Masahiko Sawada wrote:
>
> On Tue, Nov 19, 2024 at 1:14 AM Alvaro Herrera
> wrote:
> >
> > On 19/11/2024 01:20, Masahiko Sawada wrote:
> > > I realized that building test_radixtree.c with TEST_SHARED_RT fails
> > > because it eventually sets RT_SHMEM when #include
On 19/11/2024 01:20, Masahiko Sawada wrote:
> I realized that building test_radixtree.c with TEST_SHARED_RT fails
> because it eventually sets RT_SHMEM when #include'ing radixtree.h but
> it's missing some header files to include. I've attached a patch to
> include necessary header files in radixtr
On Tue, Nov 19, 2024 at 1:14 AM Alvaro Herrera wrote:
>
> On 19/11/2024 01:20, Masahiko Sawada wrote:
> > I realized that building test_radixtree.c with TEST_SHARED_RT fails
> > because it eventually sets RT_SHMEM when #include'ing radixtree.h but
> > it's missing some header files to include. I'v
On Mon, Nov 18, 2024 at 4:50 PM Tom Lane wrote:
>
> Masahiko Sawada writes:
> > On Mon, Nov 18, 2024 at 3:41 PM Heikki Linnakangas wrote:
> >> While we're at it, I noticed that lib/radixtree.h includes "postgres.h".
> >> That's against our usual convention.
>
> > Good catch. I've updated the pat
Masahiko Sawada writes:
> On Mon, Nov 18, 2024 at 3:41 PM Heikki Linnakangas wrote:
>> While we're at it, I noticed that lib/radixtree.h includes "postgres.h".
>> That's against our usual convention.
> Good catch. I've updated the patch accordingly.
Probably out of scope for this particular pat
On Mon, Nov 18, 2024 at 3:41 PM Heikki Linnakangas wrote:
>
> On 19/11/2024 01:20, Masahiko Sawada wrote:
> > I realized that building test_radixtree.c with TEST_SHARED_RT fails
> > because it eventually sets RT_SHMEM when #include'ing radixtree.h but
> > it's missing some header files to include.
On 19/11/2024 01:20, Masahiko Sawada wrote:
I realized that building test_radixtree.c with TEST_SHARED_RT fails
because it eventually sets RT_SHMEM when #include'ing radixtree.h but
it's missing some header files to include. I've attached a patch to
include necessary header files in radixtree.h t
