On Tue, Nov 19, 2024 at 2:37 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > On Tue, Nov 19, 2024 at 1:14 AM Alvaro Herrera <alvhe...@alvh.no-ip.org> > wrote: > > > > On 19/11/2024 01:20, Masahiko Sawada wrote: > > > I realized that building test_radixtree.c with TEST_SHARED_RT fails > > > because it eventually sets RT_SHMEM when #include'ing radixtree.h but > > > it's missing some header files to include. I've attached a patch to > > > include necessary header files in radixtree.h to make it > > > self-contained. > > > > If those includes are only needed when RT_SHMEM is defined, I suggest > > they should be guarded by #ifdef RT_SHMEM, per Peter E's IWYU efforts > > lately. > > Indeed. I'll incorporate it in the next version. >
I've attached the updated patches. Please review them. I think we should backpatch the fix for radixtree.h so I kept these changes separated from other changes. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
v3-0001-Remove-inclusion-of-fundamental-header-files-from.patch
Description: Binary data
v3-0002-Include-necessary-header-files-in-radixtree.h.patch
Description: Binary data
