Re: Explain Analyze (Rollback off) Suggestion

2020-05-28 Thread David G. Johnston
On Thu, May 28, 2020 at 7:52 AM Tom Lane wrote: > (BTW, adding an option for auto-rollback wouldn't change my opinion > about that. Not all side-effects of a query can be rolled back. Thus, > if there is an auto-rollback option, it mustn't be GUC-adjustable > either.) > Yeah, I've worked mysel

Re: Explain Analyze (Rollback off) Suggestion

2020-05-28 Thread Tom Lane
"David G. Johnston" writes: > The ANALYZE option should not be part of the GUC setup. Yeah. While I'm generally not in favor of putting GUCs into the mix here, the only one that seriously scares me is a GUC that would affect whether the EXPLAIN'd query executes or not. A GUC that causes buffer

Re: Explain Analyze (Rollback off) Suggestion

2020-05-28 Thread David G. Johnston
On Thu, May 28, 2020 at 6:42 AM Robert Haas wrote: > On Wed, May 27, 2020 at 9:33 PM David G. Johnston > wrote: > > I'm not seeing enough similarity with the reasons for, and specific > behaviors, of those previous GUCs to dismiss this proposal on that basis > alone. These are "crap we messed t

Re: Explain Analyze (Rollback off) Suggestion

2020-05-28 Thread Robert Haas
On Wed, May 27, 2020 at 9:33 PM David G. Johnston wrote: > I'm not seeing enough similarity with the reasons for, and specific > behaviors, of those previous GUCs to dismiss this proposal on that basis > alone. These are "crap we messed things up" switches that alter a query > behind the scene

Re: Explain Analyze (Rollback off) Suggestion

2020-05-27 Thread David G. Johnston
On Wed, May 27, 2020 at 5:31 PM Tom Lane wrote: > Robert Haas writes: > > I think the only way to make the effects of an EXPLAIN ANALYZE > > statement be automatically rolled back would be to wrap the entire > > operation in a subtransaction. While we could certainly implement > > that, it might

Re: Explain Analyze (Rollback off) Suggestion

2020-05-27 Thread Tom Lane
Robert Haas writes: > I think the only way to make the effects of an EXPLAIN ANALYZE > statement be automatically rolled back would be to wrap the entire > operation in a subtransaction. While we could certainly implement > that, it might have its own share of surprises; for example, it would > co

Re: Explain Analyze (Rollback off) Suggestion

2020-05-27 Thread Robert Haas
On Wed, May 27, 2020 at 10:48 AM David G. Johnston wrote: > The recent discussion about EXPLAIN and the possible inclusion of > default-specifying GUCs raised a behavior that I did not fully appreciate nor > find to be self-evident. Running EXPLAIN ANALYZE results in any side-effects > of the