On Sat, Jul 10, 2021 at 5:19 PM John Naylor
wrote:
> Side note for future reference: While the feature named in the CF entry has
> been rejected, the remaining 0001 patch currently proposed no longer matches
> the title, or category. It is possible within the CF app, and helpful, to
> rename th
On Tue, Mar 16, 2021 at 8:13 AM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
>
> On Tue, Mar 16, 2021 at 1:15 AM Tom Lane wrote:
> > I don't really see that this feature buys us anything you can't
> > get by explaining the view's query, so I think we're better advised
> > to
On Tue, 16 Mar 2021 at 20:13, Bharath Rupireddy
wrote:
> On Tue, Mar 16, 2021 at 1:15 AM Tom Lane wrote:
>>
>> [ Sorry for not looking at this thread sooner ]
>>
>> Bharath Rupireddy writes:
>> > Currently, $subject is not allowed. We do plan the mat view query
>> > before every refresh. I p
On Tue, Mar 16, 2021 at 1:15 AM Tom Lane wrote:
>
> [ Sorry for not looking at this thread sooner ]
>
> Bharath Rupireddy writes:
> > Currently, $subject is not allowed. We do plan the mat view query
> > before every refresh. I propose to show the explain/explain analyze of
> > the select part of
[ Sorry for not looking at this thread sooner ]
Bharath Rupireddy writes:
> Currently, $subject is not allowed. We do plan the mat view query
> before every refresh. I propose to show the explain/explain analyze of
> the select part of the mat view in case of Refresh Mat View(RMV).
TBH, I think
On Sat, Mar 13, 2021 at 7:00 AM Japin Li wrote:
>
> On Mon, 08 Mar 2021 at 12:28, Bharath Rupireddy
> wrote:
> > On Sun, Mar 7, 2021 at 10:13 PM Zhihong Yu wrote:
> >> Hi,
> >>
> >> +* EXPLAIN ANALYZE CREATE TABLE AS or REFRESH MATERIALIZED VIEW
> >> +* WITH NO DATA is weird.
>
On Mon, 08 Mar 2021 at 12:28, Bharath Rupireddy
wrote:
> On Sun, Mar 7, 2021 at 10:13 PM Zhihong Yu wrote:
>> Hi,
>>
>> +* EXPLAIN ANALYZE CREATE TABLE AS or REFRESH MATERIALIZED VIEW
>> +* WITH NO DATA is weird.
>>
>> Maybe it is clearer to spell out WITH NO DATA for both stat
On Sun, Mar 7, 2021 at 10:13 PM Zhihong Yu wrote:
> Hi,
>
> +* EXPLAIN ANALYZE CREATE TABLE AS or REFRESH MATERIALIZED VIEW
> +* WITH NO DATA is weird.
>
> Maybe it is clearer to spell out WITH NO DATA for both statements, instead of
> sharing it.
Done that way.
> - if (!stmt-
Hi,
+* EXPLAIN ANALYZE CREATE TABLE AS or REFRESH MATERIALIZED VIEW
+* WITH NO DATA is weird.
Maybe it is clearer to spell out WITH NO DATA for both statements, instead
of sharing it.
- if (!stmt->skipData)
+ if (!stmt->skipData && !explainInfo)
...
+ else if (explainInfo)
On Sun, 07 Mar 2021 at 17:33, Bharath Rupireddy
wrote:
> On Sun, Mar 7, 2021 at 12:13 PM Japin Li wrote:
>>
>> On Sun, 07 Mar 2021 at 14:25, Bharath Rupireddy
>> wrote:
>> > On Sun, Mar 7, 2021 at 11:49 AM Japin Li wrote:
>> >>
>> >> On Fri, 05 Mar 2021 at 19:48, Bharath Rupireddy
>> >> w
On Sun, Mar 7, 2021 at 12:13 PM Japin Li wrote:
>
> On Sun, 07 Mar 2021 at 14:25, Bharath Rupireddy
> wrote:
> > On Sun, Mar 7, 2021 at 11:49 AM Japin Li wrote:
> >>
> >> On Fri, 05 Mar 2021 at 19:48, Bharath Rupireddy
> >> wrote:
> >> > Attaching v5 patch set for further review.
> >> >
> >>
On Sun, 07 Mar 2021 at 14:25, Bharath Rupireddy
wrote:
> On Sun, Mar 7, 2021 at 11:49 AM Japin Li wrote:
>>
>> On Fri, 05 Mar 2021 at 19:48, Bharath Rupireddy
>> wrote:
>> > Attaching v5 patch set for further review.
>> >
>>
>> The v5 patch looks good to me, if there is no objection, I'll ch
On Sun, Mar 7, 2021 at 11:49 AM Japin Li wrote:
>
> On Fri, 05 Mar 2021 at 19:48, Bharath Rupireddy
> wrote:
> > Attaching v5 patch set for further review.
> >
>
> The v5 patch looks good to me, if there is no objection, I'll change the
> cf status to "Ready for Committer" in few days.
Thanks f
On Fri, 05 Mar 2021 at 19:48, Bharath Rupireddy
wrote:
> Attaching v5 patch set for further review.
>
The v5 patch looks good to me, if there is no objection, I'll change the
cf status to "Ready for Committer" in few days.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
On Fri, Mar 5, 2021 at 9:32 AM Japin Li wrote:
> On Thu, 04 Mar 2021 at 14:53, Bharath Rupireddy
> wrote:
> > Thanks! I will look forward for more review comments.
> >
>
> v4-0001-Rearrange-Refresh-Mat-View-Code.patch
> -
>
> +static Oid
> +get_new_hea
On Thu, 04 Mar 2021 at 14:53, Bharath Rupireddy
wrote:
> Thanks! I will look forward for more review comments.
>
v4-0001-Rearrange-Refresh-Mat-View-Code.patch
-
+static Oid
+get_new_heap_oid(RefreshMatViewStmt *stmt, Relation matviewRel, Oid matview
On Thu, Mar 4, 2021 at 11:41 AM Japin Li wrote:
> On Wed, 03 Mar 2021 at 20:56, David Steele wrote:
> > Do you know if you will have time to review this patch during the
> > current commitfest?
> >
>
> Sorry for the late reply! I think I have time to review this patch
> and I will do it later.
T
On Wed, 03 Mar 2021 at 20:56, David Steele wrote:
> Do you know if you will have time to review this patch during the
> current commitfest?
>
Sorry for the late reply! I think I have time to review this patch
and I will do it later.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology C
Hi Japin,
On 1/8/21 9:02 PM, japin wrote:
On Sat, 09 Jan 2021 at 09:38, Bharath Rupireddy wrote:
On Fri, Jan 8, 2021 at 9:50 PM japin wrote:
I ran pgindent on 0001 patch to fix the above. 0002 patch has no
changes. If I'm correct, pgindent will be run periodically on master.
Thanks for yo
On Sat, 09 Jan 2021 at 09:38, Bharath Rupireddy wrote:
> On Fri, Jan 8, 2021 at 9:50 PM japin wrote:
>> > Attaching v3 patches, please consider these for further review.
>> >
>>
>> I find that both the declaration and definition of
>> match_matview_with_new_data()
>> have a tab between type and
On Fri, Jan 8, 2021 at 9:50 PM japin wrote:
> > Attaching v3 patches, please consider these for further review.
> >
>
> I find that both the declaration and definition of
> match_matview_with_new_data()
> have a tab between type and variable. We can use pgindent to fix it.
> What do you think?
>
On Fri, 08 Jan 2021 at 17:24, Bharath Rupireddy wrote:
> On Fri, Jan 8, 2021 at 1:50 PM japin wrote:
>> Thanks for updating the patch!
>>
>> + /* Get the data generating query. */
>> + dataQuery = get_matview_query(stmt, &matviewRel, &matviewOid);
>>
>> - /*
>> -* Check
On Fri, Jan 8, 2021 at 1:50 PM japin wrote:
> Thanks for updating the patch!
>
> + /* Get the data generating query. */
> + dataQuery = get_matview_query(stmt, &matviewRel, &matviewOid);
>
> - /*
> -* Check for active uses of the relation in the current transaction,
> su
On Thu, 07 Jan 2021 at 17:53, Bharath Rupireddy wrote:
> On Mon, Dec 28, 2020 at 5:56 PM Bharath Rupireddy
> wrote:
>>
>> On Tue, Dec 22, 2020 at 7:01 PM Bharath Rupireddy
>> wrote:
>> > Currently, $subject is not allowed. We do plan the mat view query
>> > before every refresh. I propose to sh
On Mon, Dec 28, 2020 at 5:56 PM Bharath Rupireddy
wrote:
>
> On Tue, Dec 22, 2020 at 7:01 PM Bharath Rupireddy
> wrote:
> > Currently, $subject is not allowed. We do plan the mat view query
> > before every refresh. I propose to show the explain/explain analyze of
> > the select part of the mat v
On Tue, Dec 22, 2020 at 7:01 PM Bharath Rupireddy
wrote:
> Currently, $subject is not allowed. We do plan the mat view query
> before every refresh. I propose to show the explain/explain analyze of
> the select part of the mat view in case of Refresh Mat View(RMV). It
> will be useful for the user
26 matches
Mail list logo
