On Fri, Jan 8, 2021 at 9:50 PM japin <japi...@hotmail.com> wrote:
> > Attaching v3 patches, please consider these for further review.
> >
>
> I find that both the declaration and definition of 
> match_matview_with_new_data()
> have a tab between type and variable.  We can use pgindent to fix it.
> What do you think?
>
>
> static void
> match_matview_with_new_data(RefreshMatViewStmt *stmt, Relation  matviewRel,
>                                                               ^
>                             Oid matviewOid, Oid OIDNewHeap, Oid relowner,
>                             int save_sec_context, char relpersistence,
>                             uint64  processed)
>                                   ^

I ran pgindent on 0001 patch to fix the above. 0002 patch has no
changes. If I'm correct, pgindent will be run periodically on master.

Attaching v4 patch set for further review.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

Attachment: v4-0001-Rearrange-Refresh-Mat-View-Code.patch
Description: Binary data

Attachment: v4-0002-EXPLAIN-EXPLAIN-ANALYZE-REFRESH-MATERIALIZED-VIEW.patch
Description: Binary data

Reply via email to