On Thu, Mar 23, 2023 at 6:55 PM Daniel Gustafsson wrote:
> > seems more appropriate to me as well in this context, so I
> > left it alone.
>
> And just to be clear, I think you are right in leaving it alone given the
> context.
>
> > Attached is an updated version of the patch.
>
> LGTM.
Cool!
> On 23 Mar 2023, at 10:51, Etsuro Fujita wrote:
> seems more appropriate to me as well in this context, so I
> left it alone.
And just to be clear, I think you are right in leaving it alone given the
context.
> Attached is an updated version of the patch.
LGTM.
--
Daniel Gustafsson
On Wed, Mar 22, 2023 at 9:13 PM Daniel Gustafsson wrote:
> Patch looks good to me, but I agree with Tatsuo downthread that "similar way
> to
> the insert case" reads better.
Ok, I removed "in".
> Theoretically the number could be different
> from 1000 if MAX_BUFFERED_TUPLES was changed in the b
> While not the fault of this patch I find it confusing that we mix
> and for marking up "postgres_fdw", the latter seemingly more correct
> (and less commonly used) than .
I think we traditionally use for an extension module (file)
name. It seems the is used when we want to refer to objects
o
> On 22 Mar 2023, at 12:58, Etsuro Fujita wrote:
>
> On Fri, Feb 17, 2023 at 5:45 PM Etsuro Fujita wrote:
>> Here is a small patch to improve the note, which was added by commit
>> 97da48246 ("Allow batch insertion during COPY into a foreign table."),
>> by adding an explanation about how the ac
> On Fri, Feb 17, 2023 at 5:45 PM Etsuro Fujita wrote:
>> Here is a small patch to improve the note, which was added by commit
>> 97da48246 ("Allow batch insertion during COPY into a foreign table."),
>> by adding an explanation about how the actual number of rows
>> postgres_fdw inserts at once i
On Fri, Feb 17, 2023 at 5:45 PM Etsuro Fujita wrote:
> Here is a small patch to improve the note, which was added by commit
> 97da48246 ("Allow batch insertion during COPY into a foreign table."),
> by adding an explanation about how the actual number of rows
> postgres_fdw inserts at once is dete
