On Wed, Mar 22, 2023 at 9:13 PM Daniel Gustafsson <dan...@yesql.se> wrote: > Patch looks good to me, but I agree with Tatsuo downthread that "similar way > to > the insert case" reads better.
Ok, I removed "in". > Theoretically the number could be different > from 1000 if MAX_BUFFERED_TUPLES was changed in the build, but that's a > non-default not worth spending time explaining. Agreed. > + the actual number of rows <filename>postgres_fdw</filename> copies at > > While not the fault of this patch I find it confusing that we mix <filename> > and <literal> for marking up "postgres_fdw", the latter seemingly more correct > (and less commonly used) than <filename>. On Wed, Mar 22, 2023 at 9:32 PM Tatsuo Ishii <is...@sraoss.co.jp> wrote: > I think we traditionally use <filename> for an extension module (file) > name. It seems the <literal> is used when we want to refer to objects > other than files. <filename> seems more appropriate to me as well in this context, so I left it alone. Attached is an updated version of the patch. Thanks for looking, Daniel and Ishii-san! Best regards, Etsuro Fujita
postgres-fdw-batch-insert-doc-v2.patch
Description: Binary data
