Re: Declaration fixes

2022-05-12 Thread Andres Freund
On 2022-05-12 11:38:39 -0700, Andres Freund wrote: > On 2022-05-12 13:18:05 -0400, Tom Lane wrote: > > Andres Freund writes: > > > I think the attached patches are all a good idea and trivial enought that > > > I > > > think we should apply them now. > > > > +1 to all of that. > > Cool. Pushed

Re: Declaration fixes

2022-05-12 Thread Andres Freund
Hi, On 2022-05-12 13:18:05 -0400, Tom Lane wrote: > Andres Freund writes: > > I was experimenting with specifying symbol visiblity for functions > > explicitly, > > i.e. adding PGDLLIMPORT markers for them, with the goal of getting rid of > > src/tools/msvc/gendef.pl (and similar AIX stuff). Whi

Re: Declaration fixes

2022-05-12 Thread Tom Lane
Andres Freund writes: > I was experimenting with specifying symbol visiblity for functions explicitly, > i.e. adding PGDLLIMPORT markers for them, with the goal of getting rid of > src/tools/msvc/gendef.pl (and similar AIX stuff). While doing that I compared > the set of exported symbols before /