Andres Freund <and...@anarazel.de> writes: > I was experimenting with specifying symbol visiblity for functions explicitly, > i.e. adding PGDLLIMPORT markers for them, with the goal of getting rid of > src/tools/msvc/gendef.pl (and similar AIX stuff). While doing that I compared > the set of exported symbols before / after, leading me to find a few > pre-existing "issues".
> I think the attached patches are all a good idea and trivial enought that I > think we should apply them now. +1 to all of that. Would the changes you're working on result in getting warnings for these sorts of oversights on mainstream compilers? regards, tom lane