Re: DROP INDEX docs - explicit lock naming

2021-04-01 Thread Michael Paquier
On Thu, Apr 01, 2021 at 08:26:50AM -0400, Greg Rychlewski wrote: > Thanks! I apologize, I added a commitfest entry for this and failed to add > it to my message: https://commitfest.postgresql.org/33/3053/. > > This is my first time submitting a patch and I'm not sure if it needs to be > deleted no

Re: DROP INDEX docs - explicit lock naming

2021-04-01 Thread Greg Rychlewski
Thanks! I apologize, I added a commitfest entry for this and failed to add it to my message: https://commitfest.postgresql.org/33/3053/. This is my first time submitting a patch and I'm not sure if it needs to be deleted now or if you are supposed to add yourself as a committer. On Thu, Apr 1, 20

Re: DROP INDEX docs - explicit lock naming

2021-03-31 Thread Michael Paquier
On Tue, Mar 30, 2021 at 11:29:17PM -0400, Greg Rychlewski wrote: > Thanks for pointing that out. I've attached a new patch with several other > updates where I felt confident the docs were referring to an ACCESS > EXCLUSIVE lock. Thanks, applied! I have reviewed the whole and there is one place i

Re: DROP INDEX docs - explicit lock naming

2021-03-30 Thread Greg Rychlewski
Thanks for pointing that out. I've attached a new patch with several other updates where I felt confident the docs were referring to an ACCESS EXCLUSIVE lock. On Tue, Mar 30, 2021 at 8:47 PM Michael Paquier wrote: > On Tue, Mar 30, 2021 at 10:33:46AM -0400, Greg Rychlewski wrote: > > While readi

Re: DROP INDEX docs - explicit lock naming

2021-03-30 Thread Michael Paquier
On Tue, Mar 30, 2021 at 10:33:46AM -0400, Greg Rychlewski wrote: > While reading the documentation for DROP INDEX[1], I noticed the lock was > described colloquially as an "exclusive" lock, which made me pause for a > second because it's the same name as the EXCLUSIVE table lock. > > The attached