On Thu, 6 Mar 2025 at 16:36, vignesh C wrote:
> But it applies neatly for me and Jim also at [3]. Any idea why patch
> apply fails with CFbot whereas it passes in our environment?
Okay, the cause of this seems to be that the CFbot currently uses "git
apply --3way", not "git am --3way". For some r
Jelte Fennema-Nio writes:
> Okay, the cause of this seems to be that the CFbot currently uses "git
> apply --3way", not "git am --3way". For some reason "git apply" fails
> to apply the patch while "git am" succeeds. I'll check this weekend if
> I can change the logic to use "git am" instead.
Ple
On Sun, 9 Mar 2025 at 19:05, Jelte Fennema-Nio wrote:
>
> On Sun, 9 Mar 2025 at 03:21, vignesh C wrote:
> > Couple of suggestions: a) No need to show CI status as "Needs rebase,"
> > "Not processed," etc., for committed patches.
>
> Do you mean specifically for committed ones? Or just for any pat
On Sun, 9 Mar 2025 at 03:21, vignesh C wrote:
> Couple of suggestions: a) No need to show CI status as "Needs rebase,"
> "Not processed," etc., for committed patches.
Do you mean specifically for committed ones? Or just for any patch
with a "closed" status.
> b) Can we add a filter
> for "Needs
On Fri, 31 Jan 2025 at 19:54, Jelte Fennema-Nio wrote:
>
> At the FOSDEM dev meeting we discussed potential improvements to the
> commitfest app and how to handle deploying future changes with minimal
> disruption to existing workflows. We're going to try a new approach:
> announcing a new commitf
On Fri, 7 Mar 2025 at 17:42, Tom Lane wrote:
> Hm, don't you *want* a failure if the patch is already applied?
It's pretty common that in a larger patchset the first 1-2
small/trivial patches get committed before the rest. Having to then
send an additional email, resubmitting the rest of the patc
Jelte Fennema-Nio writes:
> On Fri, 7 Mar 2025 at 17:42, Tom Lane wrote:
>> Hm, don't you *want* a failure if the patch is already applied?
> It's pretty common that in a larger patchset the first 1-2
> small/trivial patches get committed before the rest. Having to then
> send an additional emai
Jelte Fennema-Nio writes:
> On Fri, 7 Mar 2025 at 11:26, Andreas Karlsson wrote:
>> Out of curiosity: do you track which method works? I would expect
>> everything to be applied with either git am or patch which can be
>> applied with git apply making git apply technically unnecessary.
> I think
On Fri, 7 Mar 2025 at 11:26, Andreas Karlsson wrote:
> Out of curiosity: do you track which method works? I would expect
> everything to be applied with either git am or patch which can be
> applied with git apply making git apply technically unnecessary.
I think we need all of them...
- git appl
On 3/7/25 12:48 AM, Jelte Fennema-Nio wrote:
Okay, I went for the approach of just trying everything until one
works. Starting with "git am", then patch(1), and as a final attempt
"git apply". Patch 5272 applies correctly now. I've removed any
backoff caused by repeated failures for all existing
Jelte Fennema-Nio writes:
> Okay, I went for the approach of just trying everything until one
> works. Starting with "git am", then patch(1), and as a final attempt
> "git apply".
+1, thanks!
regards, tom lane
On Thu, 6 Mar 2025 at 18:39, Jelte Fennema-Nio wrote:
>
> On Thu, 6 Mar 2025 at 18:10, Tom Lane wrote:
> > Please see if you can make it use patch(1). IME git is too
> > stiff-necked about slightly stale patches no matter which
> > subcommand you use.
>
> It was using patch(1) in the past for th
On Thu, 6 Mar 2025 at 18:10, Tom Lane wrote:
> Please see if you can make it use patch(1). IME git is too
> stiff-necked about slightly stale patches no matter which
> subcommand you use.
It was using patch(1) in the past for that reason, but with --3way I
was able to get "git apply" to apply pa
On Fri, 31 Jan 2025 at 19:54, Jelte Fennema-Nio wrote:
>
> At the FOSDEM dev meeting we discussed potential improvements to the
> commitfest app and how to handle deploying future changes with minimal
> disruption to existing workflows. We're going to try a new approach:
> announcing a new commitf
On Thu, Feb 20, 2025 at 11:53 PM Jelte Fennema-Nio wrote:
> On Thu, 20 Feb 2025 at 11:07, Thomas Munro wrote:
> > When the layout of https://commitfest.postgresql.org/52/ changed,
> > cfbot's web scraping logic could no longer find the authors :-(.
> > That's a stupid problem to have, that we are
>> On Thu, Feb 20, 2025 at 10:53 PM Tatsuo Ishii wrote:
>> > I noticed some of entries are shown with the author field being empty.
>> > e.g. https://commitfest.postgresql.org/patch/5525/
>>
>> When the layout of https://commitfest.postgresql.org/52/ changed,
>> cfbot's web scraping logic could no
On Thu, 20 Feb 2025 at 11:07, Thomas Munro wrote:
>
> On Thu, Feb 20, 2025 at 10:53 PM Tatsuo Ishii wrote:
> > I noticed some of entries are shown with the author field being empty.
> > e.g. https://commitfest.postgresql.org/patch/5525/
>
> When the layout of https://commitfest.postgresql.org/52/
On Thu, Feb 20, 2025 at 10:53 PM Tatsuo Ishii wrote:
> I noticed some of entries are shown with the author field being empty.
> e.g. https://commitfest.postgresql.org/patch/5525/
When the layout of https://commitfest.postgresql.org/52/ changed,
cfbot's web scraping logic could no longer find the
> At the FOSDEM dev meeting we discussed potential improvements to the
> commitfest app and how to handle deploying future changes with minimal
> disruption to existing workflows. We're going to try a new approach:
> announcing a new commitfest release ~2 weeks in advance, including
> release notes
On Wed, Feb 19, 2025 at 11:57 AM Jelte Fennema-Nio wrote:
> On Tue, 18 Feb 2025 at 00:38, Peter Geoghegan wrote:
> > On Mon, Feb 17, 2025 at 4:33 PM Thomas Munro wrote:
> > > This looks fantastic. Thanks so much for working on it! And all the
> > > other usability improvements too.
> >
> > +1.
On Tue, Feb 18, 2025 at 11:39:54PM +0100, Jelte Fennema-Nio wrote:
> On Tue, 18 Feb 2025 at 22:15, Bruce Momjian wrote:
> > Looking at the live version, I can sort the "Stats" column from smallest
> > to largest, but not from largest to smallest. Is this intended?
>
> The next release to prod in
On Tue, 18 Feb 2025 at 00:38, Peter Geoghegan wrote:
>
> On Mon, Feb 17, 2025 at 4:33 PM Thomas Munro wrote:
> > This looks fantastic. Thanks so much for working on it! And all the
> > other usability improvements too.
>
> +1.
Thanks all, I'm also very happy that it's deployed.
> I very much
On Tue, 18 Feb 2025 at 23:57, Jelte Fennema-Nio wrote:
> > I like "Useful links that you can use and bookmark", but I'd prefer if
> > there was only one link that I needed to bookmark. That is, I'd like
> > it if "Your entries in the current commitfest", "Your entries in the
> > open commitfest",
On Tue, 18 Feb 2025 at 22:15, Bruce Momjian wrote:
> Looking at the live version, I can sort the "Stats" column from smallest
> to largest, but not from largest to smallest. Is this intended?
The next release to prod in ~2 weeks will have that as one of the new
features (courtesy of Akshat).
Yo
On Tue, Feb 4, 2025 at 05:27:18PM +0100, Álvaro Herrera wrote:
> On 2025-Jan-31, Jelte Fennema-Nio wrote:
>
> > 3. Showing total additions/deletions of the most recent patchset on
> > patch and commitfest pages
> > 4. Showing additions/deletions of the first patch of the most recent
> > patchset
On Mon, Feb 17, 2025 at 06:38:07PM -0500, Peter Geoghegan wrote:
> +1. I very much welcome a more formal release process for the CF app,
> though with shorter feedback cycles.
Interesting evolution of the CF app. Thanks for all that.
--
Michael
signature.asc
Description: PGP signature
On Mon, Feb 17, 2025 at 4:33 PM Thomas Munro wrote:
> This looks fantastic. Thanks so much for working on it! And all the
> other usability improvements too.
+1. I very much welcome a more formal release process for the CF app,
though with shorter feedback cycles.
On that note: It'd be nice if
On Mon, Feb 17, 2025 at 10:03 PM Jelte Fennema-Nio wrote:
> The cfbot statuses will get filled in over the next few (12?) hours.
> The first few are already available[2]. If you notice any problems,
> please let me know.
This looks fantastic. Thanks so much for working on it! And all the
other
On Fri, 31 Jan 2025 at 15:23, Jelte Fennema-Nio wrote:
> The next commitfest app release will take place on February 17 and
> will contain the following user facing changes:
In my part of the world it's February 17th now. So this is now deployed.
A big recommendation, check the "Notify on all wh
On 2025-Feb-04, Jelte Fennema-Nio wrote:
> To be clear: the only stats column currently in the staging
> environment shows exactly this. Changes 4 and 5 are *not* visible in
> columns on the commitfest page, that info is currently only visible on
> the patch details page. (For context for others:
On Tue, 4 Feb 2025 at 17:27, Álvaro Herrera wrote:
> I think this has potential for excessive clutter. I propose that, if
> we're going to have a column with addition/deletions, we have two
> things:
>
> 1. the total number of addition and deletions in the whole patch
>series, for the last pa
On 2025-Jan-31, Jelte Fennema-Nio wrote:
> 3. Showing total additions/deletions of the most recent patchset on
> patch and commitfest pages
> 4. Showing additions/deletions of the first patch of the most recent
> patchset on the patch page
> 5. Showing the version and number of patches of the most
On Fri, Jan 31, 2025 at 03:23:56PM +0100, Jelte Fennema-Nio wrote:
> At the FOSDEM dev meeting we discussed potential improvements to the
> commitfest app and how to handle deploying future changes with minimal
> disruption to existing workflows. We're going to try a new approach:
> announcing a ne
On Fri, 31 Jan 2025 at 15:23, Jelte Fennema-Nio wrote:
> You can try out these changes on the staging environment
It seems that someone tried it out, and found a 500 error when
searching by Message-ID. That's fixed now.
I also fixed some broken links to CirrusCI on the patch page.
34 matches
Mail list logo
