On Tue, 4 Feb 2025 at 17:27, Álvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > I think this has potential for excessive clutter. I propose that, if > we're going to have a column with addition/deletions, we have two > things: > > 1. the total number of addition and deletions in the whole patch > series, for the last patchset version posted. This would be shown in > the column.
To be clear: the only stats column currently in the staging environment shows exactly this. Changes 4 and 5 are *not* visible in columns on the commitfest page, that info is currently only visible on the patch details page. (For context for others: during the FOSDEM meeting 4 was a column on the commitfest page, but I reverted that after the feedback there) So, I guess clutter wise the current staging is acceptable to you. > 2. a per-patch breakdown of the number of addition and deletions for the > last patchset version posted, one line per patch. This would appear > in a tooltip on the column for the totals, to avoid interface > clutter. Statistics for each patch would definitely be nice. Not trivial to add though, because it would need cfbot to get those statistics for each patch. I created a github issue for this idea to track it[1] > > 10. Allow sorting patches by total additions/deletions (added together > > for total lines changed) > > Seems reasonable, though I don't see much of an use-case for this. My main idea behind this is to allow people to easily find some small patchsets, for when they have ~30 minutes to review something. Or for new contributors to find something to review without getting overwhelmed. [1]: https://github.com/postgres/pgcommitfest/issues/24
