Re: Code cleanup patch submission for extended_stats.c

2017-11-28 Thread Alvaro Herrera
Mark Dilger wrote: > > > On Nov 25, 2017, at 2:05 PM, Tom Lane wrote: > > > > Mark Dilger writes: > >> It looks to me like Alvaro introduced this in the original version of the > >> file which > >> was created in commit 7b504eb282ca2f5104b5c00b4f05a3ef6bb1385b. Grep'ing > >> through the code

Re: Code cleanup patch submission for extended_stats.c

2017-11-25 Thread Michael Paquier
On Sun, Nov 26, 2017 at 11:07 AM, Mark Dilger wrote: > >> On Nov 25, 2017, at 2:05 PM, Tom Lane wrote: >> >> Mark Dilger writes: >>> It looks to me like Alvaro introduced this in the original version of the >>> file which >>> was created in commit 7b504eb282ca2f5104b5c00b4f05a3ef6bb1385b. Grep

Re: Code cleanup patch submission for extended_stats.c

2017-11-25 Thread Mark Dilger
> On Nov 25, 2017, at 2:05 PM, Tom Lane wrote: > > Mark Dilger writes: >> It looks to me like Alvaro introduced this in the original version of the >> file which >> was created in commit 7b504eb282ca2f5104b5c00b4f05a3ef6bb1385b. Grep'ing >> through the code base, it seems the following would

Re: Code cleanup patch submission for extended_stats.c

2017-11-25 Thread Tom Lane
Mark Dilger writes: > It looks to me like Alvaro introduced this in the original version of the > file which > was created in commit 7b504eb282ca2f5104b5c00b4f05a3ef6bb1385b. Grep'ing > through the code base, it seems the following would be more consistent with > how these initializations are h