Mark Dilger wrote: > > > On Nov 25, 2017, at 2:05 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > > > > Mark Dilger <hornschnor...@gmail.com> writes: > >> It looks to me like Alvaro introduced this in the original version of the > >> file which > >> was created in commit 7b504eb282ca2f5104b5c00b4f05a3ef6bb1385b. Grep'ing > >> through the code base, it seems the following would be more consistent with > >> how these initializations are handled elsewhere: > > > >> memset(nulls, 1, sizeof(nulls)); > >> memset(replaces, 0, sizeof(replaces)); > >> memset(values, 0, sizeof(values)); > > > > +1. I'd be inclined to use "false" and "true" for the init values of > > the boolean arrays, too. > > Done.
Pushed, thanks. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
