Re: Re: BUG #15039: some question about hash index code

2018-02-01 Thread Amit Kapila
On Fri, Feb 2, 2018 at 2:03 AM, Robert Haas wrote: > On Thu, Feb 1, 2018 at 1:51 AM, Amit Kapila wrote: >> Attached patch fix_markbufdirty_hash_index_v1.patch fixes the problem >> by calling MarkBufferDirty at the appropriate place in the code. >> However, I noticed that we might end up calling M

Re: Re: BUG #15039: some question about hash index code

2018-02-01 Thread Robert Haas
On Thu, Feb 1, 2018 at 1:51 AM, Amit Kapila wrote: > Attached patch fix_markbufdirty_hash_index_v1.patch fixes the problem > by calling MarkBufferDirty at the appropriate place in the code. > However, I noticed that we might end up calling MarkBufferDirty twice > for metapage in _hash_addovflpage.

Re: Re: BUG #15039: some question about hash index code

2018-01-31 Thread Amit Kapila
On Wed, Jan 31, 2018 at 6:14 PM, Amit Kapila wrote: > On Wed, Jan 31, 2018 at 5:57 PM, 自己 wrote: >> thank you for your quick reply. >> and i have another question, for the following code, whether exist such >> scene : page_found is false and >> newmapbuf is invalid, if so, may be the statement Ma

Re: Re: BUG #15039: some question about hash index code

2018-01-31 Thread Amit Kapila
On Wed, Jan 31, 2018 at 5:57 PM, 自己 wrote: > thank you for your quick reply. > and i have another question, for the following code, whether exist such > scene : page_found is false and > newmapbuf is invalid, if so, may be the statement MarkBufferDirty(metabuf); > should be placed outside the if s