Re: Add parallel columns for pg_stat_statements

2024-11-07 Thread Guillaume Lelarge
Le jeu. 7 nov. 2024 à 04:19, Michael Paquier a écrit : > On Wed, Oct 09, 2024 at 08:32:52AM +0900, Michael Paquier wrote: > > Okay, applied 0001 and 0002 then after a second lookup. I'll spend > > some more time thinking about 0003 and the other threads. > > Considered 0003, and I'm still not su

Re: Add parallel columns for pg_stat_statements

2024-11-06 Thread Michael Paquier
On Wed, Oct 09, 2024 at 08:32:52AM +0900, Michael Paquier wrote: > Okay, applied 0001 and 0002 then after a second lookup. I'll spend > some more time thinking about 0003 and the other threads. Considered 0003, and I'm still not sure that this is something that is really required based on the cor

Re: Add parallel columns for pg_stat_statements

2024-10-08 Thread Guillaume Lelarge
Le mer. 9 oct. 2024 à 01:33, Michael Paquier a écrit : > On Tue, Oct 08, 2024 at 03:53:16PM +0200, Guillaume Lelarge wrote: > > I've done a bit of testing with the three patches, and didn't find any > > issue with them. > > Okay, applied 0001 and 0002 then after a second lookup. I'll spend > som

Re: Add parallel columns for pg_stat_statements

2024-10-08 Thread Michael Paquier
On Tue, Oct 08, 2024 at 03:53:16PM +0200, Guillaume Lelarge wrote: > I've done a bit of testing with the three patches, and didn't find any > issue with them. Okay, applied 0001 and 0002 then after a second lookup. I'll spend some more time thinking about 0003 and the other threads. -- Michael

Re: Add parallel columns for pg_stat_statements

2024-10-08 Thread Guillaume Lelarge
Hi, Le mar. 8 oct. 2024 à 09:29, Michael Paquier a écrit : > On Mon, Oct 07, 2024 at 10:00:13AM +0200, Guillaume Lelarge wrote: > > Le lun. 7 oct. 2024 à 02:18, Michael Paquier a > écrit : > >> I'd recommend to split that into more independent patches: > >> - Introduce the two counters in EStat

Re: Add parallel columns for pg_stat_statements

2024-10-08 Thread Michael Paquier
On Mon, Oct 07, 2024 at 10:00:13AM +0200, Guillaume Lelarge wrote: > Le lun. 7 oct. 2024 à 02:18, Michael Paquier a écrit : >> I'd recommend to split that into more independent patches: >> - Introduce the two counters in EState with the incrementations done >> in nodeGatherMerge.c and nodeGather.c

Re: Add parallel columns for pg_stat_statements

2024-10-07 Thread Guillaume Lelarge
Le lun. 7 oct. 2024 à 02:18, Michael Paquier a écrit : > On Sun, Oct 06, 2024 at 03:32:02PM +0200, Guillaume Lelarge wrote: > > I'm not sure I follow. That would mean that every time a query is > executed, > > it always gets the same amount of workers. Which is not guaranteed to be > > true. > >

Re: Add parallel columns for pg_stat_statements

2024-10-06 Thread Michael Paquier
On Sun, Oct 06, 2024 at 03:32:02PM +0200, Guillaume Lelarge wrote: > I'm not sure I follow. That would mean that every time a query is executed, > it always gets the same amount of workers. Which is not guaranteed to be > true. > > I would agree, though, that parallelized_queries_launched is probab

Re: Add parallel columns for pg_stat_statements

2024-10-06 Thread Guillaume Lelarge
Hi Michael, Le jeu. 3 oct. 2024 à 09:15, Michael Paquier a écrit : > On Thu, Aug 29, 2024 at 10:08:23PM +0200, Guillaume Lelarge wrote: > > This patch was a bit discussed on [1], and with more details on [2]. It's > > based on another patch sent in 2022 (see [3]). It introduces seven new > > col

Re: Add parallel columns for pg_stat_statements

2024-10-03 Thread Michael Paquier
On Thu, Aug 29, 2024 at 10:08:23PM +0200, Guillaume Lelarge wrote: > This patch was a bit discussed on [1], and with more details on [2]. It's > based on another patch sent in 2022 (see [3]). It introduces seven new > columns in pg_stat_statements: > > * parallelized_queries_planned, number of ti