Re: Add exclusive backup deprecation notes to documentation

On 2019-03-29 13:54, Magnus Hagander wrote: > Is the changes to the messages going to cause issues or weirdness for > translators? That would be a reason not to backpatch it. Without that, > I'm leaning towards backpatching it. Note that the messages refer to recovery.signal, so a backpatch would

Re: Add exclusive backup deprecation notes to documentation

On Fri, Mar 29, 2019 at 1:49 PM David Steele wrote: > On 3/29/19 12:46 PM, Robert Haas wrote: > > On Fri, Mar 29, 2019 at 8:45 AM David Steele > wrote: > >> Are we planning to back-patch this? The deprecation was added to the > >> docs in 9.6 -- I think these clarifications would be helpful. >

Re: Add exclusive backup deprecation notes to documentation

On 3/29/19 12:46 PM, Robert Haas wrote: On Fri, Mar 29, 2019 at 8:45 AM David Steele wrote: Are we planning to back-patch this? The deprecation was added to the docs in 9.6 -- I think these clarifications would be helpful. I wasn't planning too, but I guess we could consider it. I'd be more

Re: Add exclusive backup deprecation notes to documentation

On Fri, Mar 29, 2019 at 8:45 AM David Steele wrote: > Are we planning to back-patch this? The deprecation was added to the > docs in 9.6 -- I think these clarifications would be helpful. I wasn't planning too, but I guess we could consider it. I'd be more inclined to back-patch the documentatio

Re: Add exclusive backup deprecation notes to documentation

On 3/29/19 12:25 PM, Magnus Hagander wrote: On Fri, Mar 29, 2019 at 1:19 PM Robert Haas > wrote: On Fri, Mar 29, 2019 at 6:27 AM David Steele mailto:da...@pgmasters.net>> wrote: > I used your suggestions with minor editing.  After some reflection, I >

Re: Add exclusive backup deprecation notes to documentation

On 3/29/19 11:58 AM, Peter Eisentraut wrote: On 2019-03-20 14:42, Magnus Hagander wrote: But that would be factually incorrect and backwards, so it seems like a terrible idea, at least when it comes to manual. If you are doing it manually, it's a lot *easier* to do it right with the non-exclusiv

Re: Add exclusive backup deprecation notes to documentation

On 2019-03-29 11:27, David Steele wrote: >> I'll revise the patch if Peter thinks this approach looks reasonable. > > Hopefully Peter's silence can be interpreted as consent. Probably just > busy, though. > > I used your suggestions with minor editing. After some reflection, I > agree that th

Re: Add exclusive backup deprecation notes to documentation

On Fri, Mar 29, 2019 at 1:19 PM Robert Haas wrote: > On Fri, Mar 29, 2019 at 6:27 AM David Steele wrote: > > I used your suggestions with minor editing. After some reflection, I > > agree that the inline warnings are likely to be more effective than > > something at the end, at least for those

Re: Add exclusive backup deprecation notes to documentation

On Fri, Mar 29, 2019 at 6:27 AM David Steele wrote: > I used your suggestions with minor editing. After some reflection, I > agree that the inline warnings are likely to be more effective than > something at the end, at least for those working on a new implementation. I'm glad we could agree on

Re: Add exclusive backup deprecation notes to documentation

On 2019-03-20 14:42, Magnus Hagander wrote: > But that would be factually incorrect and backwards, so it seems like a > terrible idea, at least when it comes to manual. If you are doing it > manually, it's a lot *easier* to do it right with the non-exclusive > mode, because you can easily keep one

Re: Add exclusive backup deprecation notes to documentation

Hi Robert, On 3/20/19 5:08 PM, David Steele wrote: I'll revise the patch if Peter thinks this approach looks reasonable. Hopefully Peter's silence can be interpreted as consent. Probably just busy, though. I used your suggestions with minor editing. After some reflection, I agree that t

Re: Add exclusive backup deprecation notes to documentation

Hi Robert, On 3/20/19 6:31 PM, Robert Haas wrote: On Wed, Mar 20, 2019 at 9:00 AM Michael Paquier wrote: On Wed, Mar 20, 2019 at 04:29:35PM +0400, David Steele wrote: Please note that there have been objections to the patch later in this thread by Peter and Robert. I'm not very interested in

Re: Add exclusive backup deprecation notes to documentation

On Wed, Mar 20, 2019 at 9:00 AM Michael Paquier wrote: > On Wed, Mar 20, 2019 at 04:29:35PM +0400, David Steele wrote: > > Please note that there have been objections to the patch later in this > > thread by Peter and Robert. I'm not very interested in watering down the > > documentation changes

Re: Add exclusive backup deprecation notes to documentation

On Mon, Mar 18, 2019 at 1:33 PM Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 2019-03-07 10:33, David Steele wrote: > > On 3/1/19 3:14 PM, Laurenz Albe wrote: > I think it would be helpful to frame the documentation in a way to > suggest that the nonexclusive mode is more for au

Re: Add exclusive backup deprecation notes to documentation

On Wed, Mar 20, 2019 at 04:29:35PM +0400, David Steele wrote: > Please note that there have been objections to the patch later in this > thread by Peter and Robert. I'm not very interested in watering down the > documentation changes as Peter suggests, but I think at the very least we > should com

Re: Add exclusive backup deprecation notes to documentation

On 3/8/19 6:08 AM, Magnus Hagander wrote: On Thu, Mar 7, 2019 at 5:35 PM Michael Paquier > wrote: On Thu, Mar 07, 2019 at 11:33:20AM +0200, David Steele wrote: > OK, here's a new version that splits the deprecation notes from the > discussion of risks. 

Re: Add exclusive backup deprecation notes to documentation

On 3/18/19 4:33 PM, Peter Eisentraut wrote: On 2019-03-07 10:33, David Steele wrote: On 3/1/19 3:14 PM, Laurenz Albe wrote: Magnus Hagander wrote: Maybe have the first note say "This method is deprecated bceause it has serious risks (see bellow)" and then list the actual risks at the end? Go

Re: Add exclusive backup deprecation notes to documentation

Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-03-18 23:35:07 -0400, Stephen Frost wrote: > > * Robert Haas (robertmh...@gmail.com) wrote: > > > On Mon, Mar 18, 2019 at 11:13 PM Stephen Frost wrote: > > > > I don't view it as up for much debate. > > > > > > In other words, you'

Re: Add exclusive backup deprecation notes to documentation

Hi, On 2019-03-18 23:35:07 -0400, Stephen Frost wrote: > * Robert Haas (robertmh...@gmail.com) wrote: > > On Mon, Mar 18, 2019 at 11:13 PM Stephen Frost wrote: > > > I don't view it as up for much debate. > > > > In other words, you're not willing to listen to what other people > > think about t

Re: Add exclusive backup deprecation notes to documentation

Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Mar 18, 2019 at 11:13 PM Stephen Frost wrote: > > I don't view it as up for much debate. > > In other words, you're not willing to listen to what other people > think about this issue. I have listened, but unfortunately the discu

Re: Add exclusive backup deprecation notes to documentation

On Mon, Mar 18, 2019 at 11:13 PM Stephen Frost wrote: > I don't view it as up for much debate. In other words, you're not willing to listen to what other people think about this issue. I can't say I haven't noticed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgr

Re: Add exclusive backup deprecation notes to documentation

Greetings, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > On 2019-03-07 10:33, David Steele wrote: > > On 3/1/19 3:14 PM, Laurenz Albe wrote: > >> Magnus Hagander wrote: > >>> Maybe have the first note say "This method is deprecated bceause it has > >>> serious > >>> risks (see be

Re: Add exclusive backup deprecation notes to documentation

On Mon, Mar 18, 2019 at 8:33 AM Peter Eisentraut wrote: > The documentation changes appear to continue the theme from the other > thread that the exclusive backup mode is terrible and everyone should > feel bad about it. I don't think there is consensus about that. +1. -- Robert Haas Enterpris

Re: Add exclusive backup deprecation notes to documentation

On 2019-03-07 10:33, David Steele wrote: > On 3/1/19 3:14 PM, Laurenz Albe wrote: >> Magnus Hagander wrote: >>> Maybe have the first note say "This method is deprecated bceause it has >>> serious >>> risks (see bellow)" and then list the actual risks at the end? >> >> Good idea. That may attract

Re: Add exclusive backup deprecation notes to documentation

On Thu, Mar 7, 2019 at 5:35 PM Michael Paquier wrote: > On Thu, Mar 07, 2019 at 11:33:20AM +0200, David Steele wrote: > > OK, here's a new version that splits the deprecation notes from the > > discussion of risks. I also fixed the indentation. > > The documentation part looks fine to me. Just

Re: Add exclusive backup deprecation notes to documentation

On Thu, Mar 07, 2019 at 11:33:20AM +0200, David Steele wrote: > OK, here's a new version that splits the deprecation notes from the > discussion of risks. I also fixed the indentation. The documentation part looks fine to me. Just one nit regarding the error hint. > - errhint("If you are no

Re: Add exclusive backup deprecation notes to documentation

On 3/1/19 3:14 PM, Laurenz Albe wrote: Magnus Hagander wrote: Maybe have the first note say "This method is deprecated bceause it has serious risks (see bellow)" and then list the actual risks at the end? Good idea. That may attract the attention of the dogs among the readers. OK, here's a

Re: Add exclusive backup deprecation notes to documentation

Magnus Hagander wrote: > Maybe have the first note say "This method is deprecated bceause it has > serious > risks (see bellow)" and then list the actual risks at the end? Good idea. That may attract the attention of the dogs among the readers. Yours, Laurenz Albe

Re: Add exclusive backup deprecation notes to documentation

On Fri, Mar 1, 2019 at 2:07 PM David Steele wrote: > On 3/1/19 1:13 PM, Peter Eisentraut wrote: > > Please follow the 1-space indentation in the documentation files. > > Whoops. Will fix. > > > I think the style of mentioning all the problems in a note before the > > actual description is a bit

Re: Add exclusive backup deprecation notes to documentation

On 3/1/19 1:13 PM, Peter Eisentraut wrote: Please follow the 1-space indentation in the documentation files. Whoops. Will fix. I think the style of mentioning all the problems in a note before the actual description is a bit backwards. In the case of an important note like this I think it

Re: Add exclusive backup deprecation notes to documentation

Please follow the 1-space indentation in the documentation files. I think the style of mentioning all the problems in a note before the actual description is a bit backwards. The layout of the section should be: - This is what it does. - Here are some comparisons with other methods. - For this

Re: Add exclusive backup deprecation notes to documentation

El vie., 1 de mar. de 2019 a la(s) 06:21, David Steele (da...@pgmasters.net) escribió: > > I added some extra language to the warning that gets emitted in the log. > Users are more like to see that than the documentation. > > I also addressed a comment from another thread by adding pg_basebackup

Re: Add exclusive backup deprecation notes to documentation

El vie., 1 de mar. de 2019 a la(s) 06:21, David Steele (da...@pgmasters.net) escribió: > > > I also addressed a comment from another thread by adding pg_basebackup > as .e.g. rather than or. Thanks David, This looks very good! -- Martín Marquéshttp://www.2ndQuadrant.com/ Postgre

Re: Add exclusive backup deprecation notes to documentation

David Steele wrote: > I added some extra language to the warning that gets emitted in the log. > Users are more like to see that than the documentation. > > I also addressed a comment from another thread by adding pg_basebackup > as .e.g. rather than or. Looks good to me. Yours, Laurenz Albe

Re: Add exclusive backup deprecation notes to documentation

On 2/28/19 6:08 PM, Laurenz Albe wrote: David Steele wrote: This patch attempts to document the limitations of the exclusive mode. Thanks! + + The primary issue with the exclusive method is that the + backup_label file is written into the data directory + when pg_start_backup

Re: Add exclusive backup deprecation notes to documentation

David Steele wrote: > This patch attempts to document the limitations of the exclusive mode. Thanks! > + > + The primary issue with the exclusive method is that the > + backup_label file is written into the data > directory > + when pg_start_backup is called and remains until > +