On Tue, Mar 12, 2024 at 8:46 PM Bharath Rupireddy
wrote:
>
> On Tue, Mar 12, 2024 at 6:05 PM Amit Kapila wrote:
> >
> > The patch looks mostly good to me. I have changed the comments and
> > commit message in the attached. I am planning to push this tomorrow
> > unless you or others have any comm
On Tue, Mar 12, 2024 at 6:05 PM Amit Kapila wrote:
>
> The patch looks mostly good to me. I have changed the comments and
> commit message in the attached. I am planning to push this tomorrow
> unless you or others have any comments on it.
LGTM.
--
Bharath Rupireddy
PostgreSQL Contributors Team
On Thu, Jan 25, 2024 at 5:07 PM Amit Kapila wrote:
>
> On Thu, Jan 25, 2024 at 4:27 PM Bharath Rupireddy
> wrote:
> >
> > Thanks. I'll wait a while and then add it to CF to not lose it in the wild.
> >
>
> Feel free to add it to CF. However, I do plan to look at it in the
> next few days.
>
The
On Thu, Jan 25, 2024 at 5:07 PM Amit Kapila wrote:
>
> On Thu, Jan 25, 2024 at 4:27 PM Bharath Rupireddy
> wrote:
> >
> > Thanks. I'll wait a while and then add it to CF to not lose it in the wild.
> >
>
> Feel free to add it to CF. However, I do plan to look at it in the
> next few days.
Thanks
On Thu, Jan 25, 2024 at 4:27 PM Bharath Rupireddy
wrote:
>
> Thanks. I'll wait a while and then add it to CF to not lose it in the wild.
>
Feel free to add it to CF. However, I do plan to look at it in the
next few days.
--
With Regards,
Amit Kapila.
On Tue, Jan 16, 2024 at 12:13 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Amit, Bharath,
>
> > This is a more strict check because it is possible that even if the
> > latest confirmed_flush location is not persisted there is no
> > meaningful decodable WAL between whatever the last confirmed_flush
Dear Amit, Bharath,
> This is a more strict check because it is possible that even if the
> latest confirmed_flush location is not persisted there is no
> meaningful decodable WAL between whatever the last confirmed_flush
> location saved on disk and the shutdown_checkpoint record.
> Kuroda-San/Vi
On Sat, Jan 13, 2024 at 4:43 PM Amit Kapila wrote:
>
> > > The current test tries to ensure that
> > > during shutdown after we shutdown walsender and ensures that it sends
> > > all the wal records and receipts an ack for the same, there is no
> > > other WAL except shutdown_checkpoint. Vignesh's
On Fri, Jan 12, 2024 at 3:36 PM Bharath Rupireddy
wrote:
>
> On Fri, Jan 12, 2024 at 9:28 AM Amit Kapila wrote:
> >
> > On Thu, Jan 11, 2024 at 10:03 PM Bharath Rupireddy
> > wrote:
> > >
> > > On Thu, Jan 11, 2024 at 4:35 PM vignesh C wrote:
> > > >
> > > > On further analysis, it was found th
On Fri, Jan 12, 2024 at 9:28 AM Amit Kapila wrote:
>
> On Thu, Jan 11, 2024 at 10:03 PM Bharath Rupireddy
> wrote:
> >
> > On Thu, Jan 11, 2024 at 4:35 PM vignesh C wrote:
> > >
> > > On further analysis, it was found that in the failing test,
> > > CHECKPOINT_SHUTDOWN was started in a new page,
On Thu, Jan 11, 2024 at 10:03 PM Bharath Rupireddy
wrote:
>
> On Thu, Jan 11, 2024 at 4:35 PM vignesh C wrote:
> >
> > On further analysis, it was found that in the failing test,
> > CHECKPOINT_SHUTDOWN was started in a new page, so there was the WAL
> > page header present just before the CHECKP
On Thu, Jan 11, 2024 at 4:35 PM vignesh C wrote:
>
> On further analysis, it was found that in the failing test,
> CHECKPOINT_SHUTDOWN was started in a new page, so there was the WAL
> page header present just before the CHECKPOINT_SHUTDOWN which was
> causing the failure. We could alternatively r
On Wed, 10 Jan 2024 at 18:37, vignesh C wrote:
>
> On Wed, 10 Jan 2024 at 14:08, Bharath Rupireddy
> wrote:
> >
> > Hi,
> >
> > I've been observing a failure in t/038_save_logical_slots_shutdown.pl
> > of late on my developer system:
> >
> > t/038_save_logical_slots_shutdown.pl .. 1/?
> > # Fai
On Wed, Jan 10, 2024 at 2:08 PM Bharath Rupireddy
wrote:
>
> I've been observing a failure in t/038_save_logical_slots_shutdown.pl
> of late on my developer system:
>
> t/038_save_logical_slots_shutdown.pl .. 1/?
> # Failed test 'Check that the slot's confirmed_flush LSN is the same
> as the lat
On Wed, Jan 10, 2024 at 6:37 PM vignesh C wrote:
>
> I got the log files from Bharath offline. Thanks Bharath for sharing
> the log files offline.
> The WAL record sequence is exactly the same in the failing test and
> tests which are passing.
> One observation in our case the confirmed flush lsn
On Wed, 10 Jan 2024 at 14:08, Bharath Rupireddy
wrote:
>
> Hi,
>
> I've been observing a failure in t/038_save_logical_slots_shutdown.pl
> of late on my developer system:
>
> t/038_save_logical_slots_shutdown.pl .. 1/?
> # Failed test 'Check that the slot's confirmed_flush LSN is the same
> as t
16 matches
Mail list logo
